Check chunk grid shape consistent upon ManifestArray init#729
Draft
TomNicholas wants to merge 4 commits intozarr-developers:mainfrom
Draft
Check chunk grid shape consistent upon ManifestArray init#729TomNicholas wants to merge 4 commits intozarr-developers:mainfrom
TomNicholas wants to merge 4 commits intozarr-developers:mainfrom
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this TODO:
VirtualiZarr/virtualizarr/manifests/array.py
Line 67 in 2e0b228
I noticed that this should be disallowed while debugging #728 (comment).
Funnily though this breaks some other tests, which potentially need to be changed to not create invalid ManifestArrays.
docs/releases.rstNew functions/methods are listed inapi.rst