WIP: Add decode_timedelta argument to open_virtual_dataset#800
Open
jbusecke wants to merge 2 commits intozarr-developers:mainfrom
Open
WIP: Add decode_timedelta argument to open_virtual_dataset#800jbusecke wants to merge 2 commits intozarr-developers:mainfrom
decode_timedelta argument to open_virtual_dataset#800jbusecke wants to merge 2 commits intozarr-developers:mainfrom
Conversation
for more information, see https://pre-commit.ci
decode_timedelta argument to open_virtual_datasetdecode_timedelta argument to open_virtual_dataset
Member
|
@jbusecke I think that the more limited typing in VirtualiZarr is just due to the function pre-dating the new typing in Xarray (added in pydata/xarray#9901). I recommend using the newer typing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have started an implementation here by simply following through the code and adding
decode_timedeltawhereverdecode_timeswas passed along.I noticed that the type hints only allowed for
bool|Nonepreviously, but xarray allows passing CFTime/TimedeltaCoder and per variable mappings. I have added these here to all relevant functions for now, but can revert this if I am missing the point of it only beingbool|None.What I am missing here are additional tests. I might need a bit of help/input to make sense of what exactly we should test here.
decode_timedeltato open_virtual_dataset #749docs/releases.rstapi.rst