Pass manifests to icechunk as pyarrow arrays#861
Draft
TomNicholas wants to merge 24 commits intozarr-developers:mainfrom
Draft
Pass manifests to icechunk as pyarrow arrays#861TomNicholas wants to merge 24 commits intozarr-developers:mainfrom
TomNicholas wants to merge 24 commits intozarr-developers:mainfrom
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (30.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
===========================================
- Coverage 89.18% 71.78% -17.40%
===========================================
Files 33 34 +1
Lines 2052 2070 +18
===========================================
- Hits 1830 1486 -344
- Misses 222 584 +362
🚀 New features to boost your workflow:
|
- Add virtualizarr/writers/arrow.py with ArrowChunkManifest class and
validation functions extracted from icechunk.py
- Refactor manifest_array fixture to use ChunkManifest.from_arrays for
scalar arrays, avoiding ambiguity around chunk keys ("c" vs "0")
- Update test_broadcast_scalar to expect the new scalar manifest format
The dict-based ChunkManifest constructor infers shape from chunk keys,
but scalar chunk key conventions differ between zarr versions. Using
from_arrays with shape=() arrays is unambiguous, matching what the HDF
parser does.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires earth-mover/icechunk#1576
Does not yet give the benefits I hoped fordocs/releases.rstapi.rst