fix: use public attribute in zarr parser#916
Merged
TomNicholas merged 1 commit intozarr-developers:mainfrom Mar 10, 2026
Merged
fix: use public attribute in zarr parser#916TomNicholas merged 1 commit intozarr-developers:mainfrom
TomNicholas merged 1 commit intozarr-developers:mainfrom
Conversation
maxrjones
requested review from
TomNicholas and
norlandrhagen
and removed request for
TomNicholas
TomNicholas
approved these changes
Mar 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 33 33
Lines 2052 2052
=======================================
Hits 1830 1830
Misses 222 222
🚀 New features to boost your workflow:
|
TomNicholas
added a commit
to TomNicholas/VirtualiZarr
that referenced
this pull request
Mar 23, 2026
- zarr-developers#880 Fix dmrpp error handling - zarr-developers#868 Fix error with Zarr-Python 3.1.0 - zarr-developers#924 Fix coordinate name issue - zarr-developers#916 Fix ZarrParser to use public attribute Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
TomNicholas
added a commit
that referenced
this pull request
Mar 23, 2026
* add empty release notes * Fix wrong PR link references in release notes - Line 57: PR text said #927 but URL pointed to #932 (correct PR) - Line 115: PR text said #565 but URL pointed to #822 (correct PR) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Move PR #818 from v2.2.0 to unreleased section This PR was merged after v2.4.0 but was incorrectly listed under the v2.2.0 release notes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add missing bug fixes to unreleased section - #880 Fix dmrpp error handling - #868 Fix error with Zarr-Python 3.1.0 - #924 Fix coordinate name issue - #916 Fix ZarrParser to use public attribute Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add missing documentation entries to unreleased section - #918 FAQ answer on "why still write native zarr?" - #893 Update FAQ regarding virtualizing existing Zarr V2 data - #937 R2 docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add missing internal change #909 to unreleased section Compiled regular expressions for improved performance. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add missing documentation entries to v2.4.0 release notes - #855 Add example of virtualizing GOES - #856 Update kerchunk comparison in FAQ Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add missing entries to v2.2.0 release notes - #829 Raise informative error on Zarr V2 parsing with Zarr-Python<3.1.3 - #805 Revert unnecessary dtype conversion in icechunk writer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug revealed in #831 (comment) for older Zarr-Python versions. follow-up to #892, so doesn't need a release note.
Also adds the zarr dependency group to more tests environments.