perf: use set_virtual_refs_arr for faster icechunk writes#967
Draft
TomNicholas wants to merge 2 commits intozarr-developers:mainfrom
Draft
perf: use set_virtual_refs_arr for faster icechunk writes#967TomNicholas wants to merge 2 commits intozarr-developers:mainfrom
TomNicholas wants to merge 2 commits intozarr-developers:mainfrom
Conversation
Replaces the Python loop that creates per-chunk VirtualChunkSpec objects with a single call to store.set_virtual_refs_arr(), passing the manifest's numpy arrays directly to Rust. ~2.8x faster for writing virtual refs against object storage (12.4s → 4.5s for 6 vars × 520k chunks each). Requires icechunk with set_virtual_refs_arr (earth-mover/icechunk#2049). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (73.06%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
===========================================
- Coverage 89.31% 73.06% -16.26%
===========================================
Files 33 33
Lines 2031 2027 -4
===========================================
- Hits 1814 1481 -333
- Misses 217 546 +329
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VirtualChunkSpecobjects with a single call tostore.set_virtual_refs_arr(), passing the manifest's numpy arrays directly to RustDepends on earth-mover/icechunk#2049.