refactor: bring in types from zarr-metadata#3961
Open
d-v-b wants to merge 30 commits into
Open
Conversation
github-actions
Bot
added
the
needs release notes
Contributor
Author
|
cc @chuckwondo |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3961 +/- ##
==========================================
- Coverage 93.29% 93.28% -0.02%
==========================================
Files 87 87
Lines 11753 11742 -11
==========================================
- Hits 10965 10953 -12
- Misses 788 789 +1
🚀 New features to boost your workflow:
|
ilan-gold
reviewed
May 11, 2026
Closed
…into use-zarr-metadata
- set `zarr-metadata` to resolve locally in local development - add a section to the docs outlining the relationship between zarr and zarr-metadata packages
…e the lower zarr-metadata bound is published
github-actions
Bot
removed
the
needs release notes
…d drop workspaces for min deps test
…ck via pre-commit
Contributor
Author
|
we should not merge this until #3972 is sorted out. that PR switches our pre-commit mypy check to run in a locked environment, which can include the package-local copy of |
d-v-b
commented
May 15, 2026
d-v-b
commented
May 15, 2026
d-v-b
commented
May 15, 2026
Comment on lines
+450
to
+451
| if self.zarr_format == 2: | ||
| result.pop("node_type", None) |
Contributor
Author
There was a problem hiding this comment.
node_type is not a valid field in v2 group metadata, so arguably this was a bug. but we also don't use to_dict for creating our v2 metadata, so while correct, this change doesn't fix any broken behavior.
d-v-b
commented
May 15, 2026
These constants were added to zarr-metadata in-tree on this branch (commit 08334d4). zarr-python cannot consume them until they appear in the zarr-metadata version pinned by the project floor — the min_deps env caught this when it installed zarr-metadata==0.1.1 from PyPI and pytest blew up on import. Reverting the test-side adoption here. The constants will be split out into a separate PR against main and consumed once released. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This reverts commit 08334d4.
This reverts commit a83537c.
…data After reverting a83537c from this branch, BytesCodecObject in zarr-metadata 0.1.1 (the project floor) still requires `configuration`. The bare `{"name": "bytes"}` form is correct per spec and at runtime, but doesn't type-check against the strict 0.1.1 shape. Drop the annotation here; the field-relaxation fix has been split out to a separate PR against main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces some of our types with exports from zarr-metadata. I expect a few related PRs, alternating between ones like this (importing types) and ones that add missing types to zarr-metadata.
TODO:
docs/user-guide/*.mdchanges/