Skip to content

fix(VEG-3633): Refactor the connector commands#319

Merged
saikambaiyyagari merged 1 commit intomasterfrom
skambaiyyagari/veg-tbd-fixes
Mar 12, 2026
Merged

fix(VEG-3633): Refactor the connector commands#319
saikambaiyyagari merged 1 commit intomasterfrom
skambaiyyagari/veg-tbd-fixes

Conversation

@saikambaiyyagari
Copy link
Contributor

@saikambaiyyagari saikambaiyyagari commented Mar 9, 2026

Description

Summary

  • bundle command: Simplified the CLI interface by removing --input/--output flags in favor of a positional path argument. The command now resolves paths relative to the connector root directory (defaulting to the current directory), and output
    defaults to /dist. Also moved the TypeScript success spinner message to after the type check completes, and improved error output color (cyan → red).
  • create command: Removed the --author flag; author is no longer scaffolded into the connector template during creation. Improved error message color consistency (cyan → red).
  • assetsValidation: Changed behavior so that a missing assets directory is now a hard validation error rather than a silent no-op. Updated the corresponding test to assert the error is thrown.
  • manifestValidation: Improved the error message to reference the specific file (index.ts) and the correct bundle command invocation.

c4c0157 Refactor the connector commands

Detail

Ref: https://zendesk.atlassian.net/browse/VEG-3633

Checklist

  • 💂‍♂️ includes new unit and functional tests

@saikambaiyyagari saikambaiyyagari requested a review from a team as a code owner March 9, 2026 01:14
Copilot AI review requested due to automatic review settings March 9, 2026 01:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the zcli connectors CLI to streamline the bundle/create workflows and tighten validation behavior, aligning error output and improving diagnostics.

Changes:

  • Simplifies connectors:bundle by removing --input/--output in favor of an optional positional connector-root path and defaulting output to <root>/dist.
  • Updates validation behavior so missing dist/assets is a hard error and adjusts the related unit test.
  • Removes --author from connectors:create and adjusts some error output coloring and messaging.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/zcli-connectors/src/lib/validations/manifestValidation.ts Updates manifest validation error guidance to reference the connector source file and bundle invocation.
packages/zcli-connectors/src/lib/validations/assetsValidation.ts Makes missing assets directory a validation failure instead of a no-op.
packages/zcli-connectors/src/lib/validations/assetsValidation.test.ts Updates unit test to assert the new missing-assets error behavior.
packages/zcli-connectors/src/commands/connectors/create.ts Removes --author flag usage and updates create-time replacements and error coloring.
packages/zcli-connectors/src/commands/connectors/bundle.ts Refactors bundle command interface to accept connector-root path and sets output to <root>/dist, plus adjusts spinner timing and error color.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-tbd-fixes branch from f2c4925 to a0bc82c Compare March 11, 2026 12:06
Copilot AI review requested due to automatic review settings March 11, 2026 12:11
@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-tbd-fixes branch from a0bc82c to 2ef4269 Compare March 11, 2026 12:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-tbd-fixes branch from 2ef4269 to 6c7baf9 Compare March 11, 2026 12:33
Copilot AI review requested due to automatic review settings March 11, 2026 12:35
@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-tbd-fixes branch from 6c7baf9 to 76221e3 Compare March 11, 2026 12:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-tbd-fixes branch from 76221e3 to c4c0157 Compare March 11, 2026 22:08
@saikambaiyyagari saikambaiyyagari merged commit 5faa22c into master Mar 12, 2026
7 checks passed
@saikambaiyyagari saikambaiyyagari deleted the skambaiyyagari/veg-tbd-fixes branch March 12, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants