feat(VEG-3618): Adds the status command to display the provisioning status of a connector#320
Merged
saikambaiyyagari merged 1 commit intomasterfrom Mar 17, 2026
Conversation
2ebea63 to
83d52d4
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new CLI command to check provisioning status for published connectors, alongside underlying API support and related test updates.
Changes:
- Introduces
connectors:publish:statuscommand that readsdist/manifest.jsonand displays provisioning status from the API. - Adds
getProvisioningStatuspublish library helper (plus unit tests) to call the Flowstate provisioning status endpoint. - Renames publish flow identifier from
jobIdtoprovisioningIdacross publish code/tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/zcli-connectors/tests/functional/status.test.ts | Adds functional tests for the new status command behavior and error cases. |
| packages/zcli-connectors/tests/functional/publish.test.ts | Updates functional publish tests for jobId → provisioningId. |
| packages/zcli-connectors/src/lib/publish/status.ts | Adds API client helper for provisioning status lookup. |
| packages/zcli-connectors/src/lib/publish/status.test.ts | Adds unit tests for the new status API helper. |
| packages/zcli-connectors/src/lib/publish/publish.ts | Changes createConnector return shape to include provisioningId instead of jobId. |
| packages/zcli-connectors/src/lib/publish/publish.test.ts | Updates unit tests for createConnector to assert provisioningId. |
| packages/zcli-connectors/src/commands/connectors/publish/status.ts | Adds the new connectors:publish:status CLI command implementation. |
| packages/zcli-connectors/src/commands/connectors/publish/index.ts | Updates publish command to use provisioningId when polling. |
Comments suppressed due to low confidence (1)
packages/zcli-connectors/src/commands/connectors/publish/index.ts:107
pollProvisioningStatusstill names its second parameterjobId(and its docs refer to a job ID), but this call site now usesprovisioningId. To avoid confusion about what identifier the API expects, either rename the local variable back tojobIdhere, or update the poller function signature/docs to consistently useprovisioningIdin the same PR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
83d52d4 to
8c0ad73
Compare
zFlabmonsta
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
connectors:publish:statuscommand that fetches and displays the current provisioning status of a connector that has been published to Zendesk. It automatically reads the connector name from the manifest.json file in the dist directory and queries the provisioning system to show the current state.8c0ad73Adds the status command to connectors namespaceDetail
JIRA: https://zendesk.atlassian.net/browse/VEG-3645
Checklist