Skip to content

feat(VEG-3618): Adds the status command to display the provisioning status of a connector#320

Merged
saikambaiyyagari merged 1 commit intomasterfrom
skambaiyyagari/fix-publish-command-add-status-command
Mar 17, 2026
Merged

feat(VEG-3618): Adds the status command to display the provisioning status of a connector#320
saikambaiyyagari merged 1 commit intomasterfrom
skambaiyyagari/fix-publish-command-add-status-command

Conversation

@saikambaiyyagari
Copy link
Contributor

@saikambaiyyagari saikambaiyyagari commented Mar 17, 2026

Description

Adds connectors:publish:status command that fetches and displays the current provisioning status of a connector that has been published to Zendesk. It automatically reads the connector name from the manifest.json file in the dist directory and queries the provisioning system to show the current state.

8c0ad73 Adds the status command to connectors namespace

Detail

JIRA: https://zendesk.atlassian.net/browse/VEG-3645

Checklist

  • 💂‍♂️ includes new unit and functional tests

@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/fix-publish-command-add-status-command branch from 2ebea63 to 83d52d4 Compare March 17, 2026 04:24
@saikambaiyyagari saikambaiyyagari marked this pull request as ready for review March 17, 2026 04:25
@saikambaiyyagari saikambaiyyagari requested a review from a team as a code owner March 17, 2026 04:25
Copilot AI review requested due to automatic review settings March 17, 2026 04:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new CLI command to check provisioning status for published connectors, alongside underlying API support and related test updates.

Changes:

  • Introduces connectors:publish:status command that reads dist/manifest.json and displays provisioning status from the API.
  • Adds getProvisioningStatus publish library helper (plus unit tests) to call the Flowstate provisioning status endpoint.
  • Renames publish flow identifier from jobId to provisioningId across publish code/tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/zcli-connectors/tests/functional/status.test.ts Adds functional tests for the new status command behavior and error cases.
packages/zcli-connectors/tests/functional/publish.test.ts Updates functional publish tests for jobIdprovisioningId.
packages/zcli-connectors/src/lib/publish/status.ts Adds API client helper for provisioning status lookup.
packages/zcli-connectors/src/lib/publish/status.test.ts Adds unit tests for the new status API helper.
packages/zcli-connectors/src/lib/publish/publish.ts Changes createConnector return shape to include provisioningId instead of jobId.
packages/zcli-connectors/src/lib/publish/publish.test.ts Updates unit tests for createConnector to assert provisioningId.
packages/zcli-connectors/src/commands/connectors/publish/status.ts Adds the new connectors:publish:status CLI command implementation.
packages/zcli-connectors/src/commands/connectors/publish/index.ts Updates publish command to use provisioningId when polling.
Comments suppressed due to low confidence (1)

packages/zcli-connectors/src/commands/connectors/publish/index.ts:107

  • pollProvisioningStatus still names its second parameter jobId (and its docs refer to a job ID), but this call site now uses provisioningId. To avoid confusion about what identifier the API expects, either rename the local variable back to jobId here, or update the poller function signature/docs to consistently use provisioningId in the same PR.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@saikambaiyyagari saikambaiyyagari changed the title Adds the status command to connectors namespace feat(VEG-3618): Adds the status command to display the provisioning status of a connector Mar 17, 2026
@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/fix-publish-command-add-status-command branch from 83d52d4 to 8c0ad73 Compare March 17, 2026 05:15
@saikambaiyyagari saikambaiyyagari merged commit 09113cc into master Mar 17, 2026
7 checks passed
@saikambaiyyagari saikambaiyyagari deleted the skambaiyyagari/fix-publish-command-add-status-command branch March 17, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants