fix: missing dependencies when running connectors:bundle#321
Open
zFlabmonsta wants to merge 1 commit intomasterfrom
Open
fix: missing dependencies when running connectors:bundle#321zFlabmonsta wants to merge 1 commit intomasterfrom
zFlabmonsta wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes zcli connectors:bundle failing at build-time due to Babel preset resolution (missing @babel/preset-env) when bundling connectors via Vite/Rollup.
Changes:
- Add
@babel/preset-envas a runtime dependency of@zendesk/zcli-connectors. - Update the Rollup Babel plugin config to resolve the preset via
require.resolve(...)instead of relying on consumer/package CWD resolution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/zcli-connectors/src/lib/vite/vite-config.ts |
Ensures Babel preset resolves from the CLI package by using require.resolve('@babel/preset-env'). |
packages/zcli-connectors/package.json |
Adds @babel/preset-env to runtime dependencies so bundling has the needed preset available. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cab8c95fix: missing dependencies when running connectors:bundleDetail
Checklist