Skip to content

fix: missing dependencies when running connectors:bundle#321

Open
zFlabmonsta wants to merge 1 commit intomasterfrom
zflabmonsta/zcli-connectors
Open

fix: missing dependencies when running connectors:bundle#321
zFlabmonsta wants to merge 1 commit intomasterfrom
zflabmonsta/zcli-connectors

Conversation

@zFlabmonsta
Copy link
Contributor

@zFlabmonsta zFlabmonsta commented Mar 18, 2026

Description

cab8c95 fix: missing dependencies when running connectors:bundle

~/Code/zendesk » zcli connectors:bundle test-connector                                                                                                                                                           130 ↵ peter.nguyen@KHRP49XN6Y
✔ TypeScript compilation check passed
⠋ Bundling connector from /Users/peter.nguyen/Code/zendesk/test-connector to /Users/peter.nguyen/Code/zendesk/test-connector/dist...vite v7.3.1 building client environment for production...
✓ 0 modules transformed.
✗ Build failed in 26ms
Vite build failed: [babel] Cannot find package '@babel/preset-env' imported from /Users/peter.nguyen/Code/zendesk/babel-virtual-resolve-base.js
file: /Users/peter.nguyen/Code/zendesk/test-connector/src/index.ts
    at captureLargerStackTrace (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/vendor/import-meta-resolve.js:516:11)
    at new NodeError (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/vendor/import-meta-resolve.js:460:5)
    at packageResolve (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/vendor/import-meta-resolve.js:1970:9)
    at moduleResolve (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/vendor/import-meta-resolve.js:2048:18)
    at defaultResolve (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/vendor/import-meta-resolve.js:2224:15)
    at resolve (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/vendor/import-meta-resolve.js:2262:12)
    at tryImportMetaResolve (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/files/plugins.ts:154:51)
    at resolveStandardizedNameForImport (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/files/plugins.ts:184:19)
    at resolvePreset (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/files/plugins.ts:200:22)
    at resolver (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/files/plugins.ts:50:32)
    at loadPreset.next (<anonymous>)
    at createDescriptor (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/config-descriptors.ts:325:35)
    at createDescriptor.next (<anonymous>)
    at step (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:261:32)
    at evaluateAsync (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:291:5)
    at /Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:44:11
    at Array.forEach (<anonymous>)
    at Function.async (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:43:15)
    at Function.all (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:216:13)
    at Generator.next (<anonymous>)
    at createDescriptors (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/config-descriptors.ts:266:38)
    at createDescriptors.next (<anonymous>)
    at createPresetDescriptors (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/config-descriptors.ts:240:17)
    at createPresetDescriptors.next (<anonymous>)
    at /Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/config-descriptors.ts:155:36
    at Generator.next (<anonymous>)
    at Function.<anonymous> (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/gensync-utils/async.ts:10:3)
    at Generator.next (<anonymous>)
    at step (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:269:25)
    at evaluateAsync (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:291:5)
    at Function.errback (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:113:7)
    at errback (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/gensync-utils/async.ts:88:18)
    at async (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:188:17)
    at onFirstPause (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:216:13)
    at Generator.next (<anonymous>)
    at presets (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/caching.ts:131:34)
    at cachedFunction.next (<anonymous>)
    at mergeChainOpts (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/config-chain.ts:727:34)
    at mergeChainOpts.next (<anonymous>)
    at loadProgrammaticChain (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/config-chain.ts:663:14)
    at chainWalker.next (<anonymous>)
    at buildRootChain (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/config-chain.ts:151:36)
    at buildRootChain.next (<anonymous>)
    at loadPrivatePartialConfig (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/partial.ts:110:44)
    at loadPrivatePartialConfig.next (<anonymous>)
    at loadPartialConfig (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/config/partial.ts:169:12)
    at loadPartialConfig.next (<anonymous>)
    at step (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:269:25)
    at /Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:273:13
    at async.call.result.err.err (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:223:11)
    at cb (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:189:28)
    at /Users/peter.nguyen/Code/zendesk/zcli/node_modules/@babel/core/src/gensync-utils/async.ts:90:7
    at /Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:113:33
    at step (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:287:14)
    at /Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:273:13
    at async.call.result.err.err (/Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:223:11)
    at /Users/peter.nguyen/Code/zendesk/zcli/node_modules/gensync/index.js:37:40
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'PLUGIN_ERROR',
  pluginCode: 'ERR_MODULE_NOT_FOUND',
  plugin: 'babel',
  hook: 'transform',
  id: '/Users/peter.nguyen/Code/zendesk/test-connector/src/index.ts',
  watchFiles: [ '/Users/peter.nguyen/Code/zendesk/test-connector/src/index.ts' ]
}
✖ Bundle failed with errors!
Found 1 error(s)
Error: [babel] Cannot find package '@babel/preset-env' imported from /Users/peter.nguyen/Code/zendesk/babel-virtual-resolve-base.js
file: /Users/peter.nguyen/Code/zendesk/test-connector/src/index.ts
✖ Failed to bundle the connector
 ›   Error: Connector build failed

Detail

Checklist

  • 💂‍♂️ includes new unit and functional tests

@zFlabmonsta zFlabmonsta marked this pull request as ready for review March 18, 2026 08:19
@zFlabmonsta zFlabmonsta requested a review from a team as a code owner March 18, 2026 08:19
Copilot AI review requested due to automatic review settings March 18, 2026 08:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes zcli connectors:bundle failing at build-time due to Babel preset resolution (missing @babel/preset-env) when bundling connectors via Vite/Rollup.

Changes:

  • Add @babel/preset-env as a runtime dependency of @zendesk/zcli-connectors.
  • Update the Rollup Babel plugin config to resolve the preset via require.resolve(...) instead of relying on consumer/package CWD resolution.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/zcli-connectors/src/lib/vite/vite-config.ts Ensures Babel preset resolves from the CLI package by using require.resolve('@babel/preset-env').
packages/zcli-connectors/package.json Adds @babel/preset-env to runtime dependencies so bundling has the needed preset available.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants