Add missing heading: Repository URL
#56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the missing `Repository URL` heading. Signed-off-by: Eric Bouchut <ebouchut@gmail.com>
Member
|
@ebouchut why are you commenting your own PRs with LGTM? |
Contributor
Author
|
I am used to review my own PRs like this. Nothing egotistical only a self check to make sure I have not missed something. |
Member
|
Ok. This is very uncommon practice in the OSS space – I've never seen that, and it's just kind of odd? If your PR is not ready, you create a draft PR. If it's not a draft, it's by design ready to be reviewed and merged. |
Contributor
Author
|
Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing
Repository URLheading.