Enable nxp high speed comparator (hscmp) driver #100629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOC_LPC55S36 has 119 IRQs. Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
add HSCMP clock support. Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
Add high-speed comparator support Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
ZhaoxiangJin
changed the title
enable hscmp for lpc55s36 Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
enable gpio_loopback for lpcxpresso55s36 Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
ZhaoxiangJin
force-pushed
the
enable-hscmp
branch
from
6eab01c to
36b1f3f
Compare
|
zephyrbot
added
area: Tests
zephyrbot
requested review from
Holt-Sun,
bjarki-andreasen,
butok,
dbaluta,
manuargue,
mmahadevan108,
nashif,
nordic-krch and
zejiang0jason
bjarki-andreasen
approved these changes
Dec 8, 2025
Holt-Sun
approved these changes
Dec 10, 2025
| return ret; | ||
| } | ||
|
|
||
| ret = reset_line_deassert(config->reset.dev, config->reset.id); |
Contributor
There was a problem hiding this comment.
assert & deassert can be combined to reset_line_toggle https://github.com/zephyrproject-rtos/zephyr/blob/main/include/zephyr/drivers/reset.h#L342-L351
| base->CCR1 &= ~HSCMP_CCR1_COUT_SEL_MASK; | ||
| if (config->filter_count != 0U) { | ||
| base->CCR1 |= HSCMP_CCR1_FILT_CNT(config->filter_count); | ||
| base->CCR1 |= HSCMP_CCR1_FILT_PER(config->filter_period); |
Contributor
There was a problem hiding this comment.
If no special hardware limitation, suggest combine to one register write, because register writing needs more time.
| base->CCR2 = ((base->CCR2 & ~(HSCMP_CCR2_CMP_HPMD_MASK | HSCMP_CCR2_CMP_NPMD_MASK | | ||
| HSCMP_CCR2_HYSTCTR_MASK | HSCMP_CCR2_PSEL_MASK | HSCMP_CCR2_MSEL_MASK)) | | ||
| HSCMP_CCR2_PSEL(config->positive_mux_is_dac ? 5U : config->positive_mux_input) | | ||
| HSCMP_CCR2_MSEL(config->negative_mux_is_dac ? 5U : config->negative_mux_input) | |
Contributor
There was a problem hiding this comment.
can use some meaningful value instead of 5?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable nxp hscmp driver
enable hscmp for lpc55s36
test with gpio_loopback
test result:
Logs