fix: serve default bind address 127.0.0.1 → 0.0.0.0#14
Open
chaosreload wants to merge 1 commit intozerobootdev:mainfrom
Open
fix: serve default bind address 127.0.0.1 → 0.0.0.0#14chaosreload wants to merge 1 commit intozerobootdev:mainfrom
chaosreload wants to merge 1 commit intozerobootdev:mainfrom
Conversation
zeroboot serve previously bound to 127.0.0.1, which breaks container environments where health probes and traffic arrive on the Pod/container IP rather than localhost: - Kubernetes: kubelet readiness/liveness probes connect from Pod IP - Docker: health checks connect via bridge network - Any reverse proxy or load balancer forwarding to the container Change the default bind to 0.0.0.0 (all interfaces) and add a --bind flag so users can still restrict to localhost for local development: zeroboot serve python:/workdir/python 8080 # 0.0.0.0 (default) zeroboot serve python:/workdir/python 8080 --bind 127.0.0.1 # localhost only The ZEROBOOT_BIND env var in the Docker entrypoint passes through to this flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
zeroboot servebinds to127.0.0.1by default, which breaks any container or networked deployment:docker exectraffic arrive via bridge network IPFix
Change the default bind address to
0.0.0.0(all interfaces) and add a--bindflag for explicit control:Backwards compatibility
The only behavior change is the default bind address. Existing local setups are unaffected in practice (loopback connections still work when the server listens on 0.0.0.0). Users who explicitly want localhost-only can pass
--bind 127.0.0.1.