Zig Build System > Testing: fix code examples#566
Open
generalmimon wants to merge 1 commit intoziglang:mainfrom
Open
Zig Build System > Testing: fix code examples#566generalmimon wants to merge 1 commit intoziglang:mainfrom
generalmimon wants to merge 1 commit intoziglang:mainfrom
Conversation
generalmimon
force-pushed
the
fix-unit-testing-examples
branch
from
91fc966 to
f707bfe
Compare
This follows up on ziglang#545. Although it did fix one compile error, fixing it actually revealed other issues that are addressed by this pull request: 1. Both versions of `main.zig` were using the old `std.ArrayList` API from when it was managed, but as of Zig 0.15.1, it is no longer managed: https://ziglang.org/download/0.15.1/release-notes.html#ArrayList-make-unmanaged-the-default 2. The file `unit-testing-skip-foreign/build.zig` was missing `additional_option=test`, so the command `zig build --summary all` was run instead of the intended command `zig build test --summary all`.
generalmimon
force-pushed
the
fix-unit-testing-examples
branch
from
f707bfe to
3165266
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on #545. Although it did fix one compile error, fixing it actually revealed other issues that are addressed by this pull request:
Both versions of
main.zigwere using the oldstd.ArrayListAPI from when it was managed, but as of Zig 0.15.1, it is no longer managed: https://ziglang.org/download/0.15.1/release-notes.html#ArrayList-make-unmanaged-the-defaultThe file
unit-testing-skip-foreign/build.zigwas missingadditional_option=test, so the commandzig build --summary allwas run instead of the intended commandzig build test --summary all.