io_uring(tests): Fix 1/N valgrind reports #26062
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is the first patch for fixing errors reported by valgrind in the `IoUring.zig` tests. This commit addresses the following: ``` 7/41 IoUring.test.write_fixed/read_fixed...==47580== Conditional jump or move depends on uninitialised value(s) ==47580== at 0x112089D: testing.expectEqualSlices__anon_24471 (testing.zig:365) ==47580== by 0x1133491: IoUring.test.write_fixed/read_fixed (IoUring.zig:2224) ==47580== by 0x11B320A: test_runner.mainTerminal (test_runner.zig:248) ==47580== by 0x11AE5DE: test_runner.main (test_runner.zig:71) ==47580== by 0x11ADE18: callMain (start.zig:705) ==47580== by 0x11ADE18: callMainWithArgs (start.zig:674) ==47580== by 0x11ADE18: main (start.zig:689) ==47580== ==47580== Conditional jump or move depends on uninitialised value(s) ==47580== at 0x112089D: testing.expectEqualSlices__anon_24471 (testing.zig:365) ==47580== by 0x113353C: IoUring.test.write_fixed/read_fixed (IoUring.zig:2225) ==47580== by 0x11B320A: test_runner.mainTerminal (test_runner.zig:248) ==47580== by 0x11AE5DE: test_runner.main (test_runner.zig:71) ==47580== by 0x11ADE18: callMain (start.zig:705) ==47580== by 0x11ADE18: callMainWithArgs (start.zig:674) ==47580== by 0x11ADE18: main (start.zig:689) ==47580== ==47580== Conditional jump or move depends on uninitialised value(s) ==47580== at 0x112089D: testing.expectEqualSlices__anon_24471 (testing.zig:365) ==47580== by 0x11335E7: IoUring.test.write_fixed/read_fixed (IoUring.zig:2226) ==47580== by 0x11B320A: test_runner.mainTerminal (test_runner.zig:248) ==47580== by 0x11AE5DE: test_runner.main (test_runner.zig:71) ==47580== by 0x11ADE18: callMain (start.zig:705) ==47580== by 0x11ADE18: callMainWithArgs (start.zig:674) ==47580== by 0x11ADE18: main (start.zig:689) ==47580== ``` The memory for the buffer[1] is never explicitly initialized, hence valgrind's report. I opted to simply initialize the memory to a default value of 0. Happy to discuss a different approach if preferred.
saulecabrera
force-pushed
the
valgrind-iouring-1
branch
from
a9531cb to
e0fe00f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24753
This commit is the first patch for fixing errors reported by valgrind in the
IoUring.zigtests. This commit addresses the following:The memory for the buffer[1] is never explicitly initialized, hence valgrind's report.
I opted to simply initialize the memory to a default value of 0. Happy to discuss a different approach if preferred.