-
Notifications
You must be signed in to change notification settings - Fork 935
Add basic support for TZE284_hodyryli #4520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4520 +/- ##
==========================================
+ Coverage 92.24% 92.29% +0.04%
==========================================
Files 369 371 +2
Lines 12094 12168 +74
==========================================
+ Hits 11156 11230 +74
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It looks like it's sort of working, but it seems the temp probe scaling is off. It may be a factor of 2 but I cannot tell for sure. I'm going to put it in a different location and check. zha-01JES93Y4NY89NXK3P04DYJNK0-_TZE284_hodyryli TS0601-0a2f9ff57075b050d6b4c6364ca08d3c (1).json |
|
I put it out in the garage, and the two temperature lines still have the same shape, but it's not off by a factor of two. next step is put the probe in the freezer to confirm it's reading two different temperatures. |
|
found this: Koenkk/zigbee2mqtt#29627 looks like maybe the external probe temp needs some massaging? |
|
looking more into that other PR, there was some general tidbits that seems less specific to internal/external probe: |
|
reading through your code, maybe you're already attempting to read it as 32bit signed. do we need to confirm big endian? ('m a python/quirk noobie) |
|
SOLVED: sorry about the long posts. change the /100 -> /10 for the external sensor and it looks good. |
zhaquirks/tuya/tuya_sensor.py
Outdated
| dp_id=38, | ||
| attribute_name="temperature_external", | ||
| type=t.int32s, | ||
| converter=lambda x: x / 100, # Divide by 100 to get correct temperature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you set this to /10 it seems to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my device /10 is provided a temperature of 510.0 °C
What is very strange, cause in ZB2MQTT is also /10.
And the only visible reason is the Chinese random in the device firmware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my device /10 is provided a temperature of 510.0 °C What is very strange, cause in ZB2MQTT is also /10. And the only visible reason is the Chinese random in the device firmware.
:)
I'm also trying to get DP17 for the time format, but my device never sends it. |
8d7c5ce to
0d77ae6
Compare
|
After reboot (change of batteries), my device started sending probe temperature in the same way as @seanmahrt, so I changed multiplayer to 10. |





Proposed change
Additional information
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black