Skip to content

fix crash when failed to load document becomes lsp synced #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techatrix merged 1 commit into from
Feb 17, 2026
Merged

fix crash when failed to load document becomes lsp synced #2610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/DocumentStore.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,13 +1377,15 @@ fn createAndStoreDocument(
store: *DocumentStore,
uri: Uri,
/// Takes ownership.
/// `file_source == .text` implies `options.lsp_synced == true`.
file_source: FileSource,
options: CreateAndStoreOptions,
) ReadFileError!*Handle {
const tracy_zone = tracy.trace(@src());
defer tracy_zone.end();

std.debug.assert(!(options.lsp_synced and !options.override));
std.debug.assert(!(options.lsp_synced and file_source == .uri));

switch (file_source) {
.text => {},
Expand Down Expand Up @@ -1422,7 +1424,7 @@ fn createAndStoreDocument(
} else |err| {
const retry = switch (err) {
error.Canceled => true,
else => false,
else => file_source == .text,
};
if (options.override and !retry) return err;
previous_err = err;
Expand Down