Skip to content

test: add config validation tests#161

Open
haosenwang1018 wants to merge 2 commits intozilliztech:mainfrom
haosenwang1018:test/config-validation-tests
Open

test: add config validation tests#161
haosenwang1018 wants to merge 2 commits intozilliztech:mainfrom
haosenwang1018:test/config-validation-tests

Conversation

@haosenwang1018
Copy link
Copy Markdown
Contributor

Adds configuration validation tests (#114).

All 6 tests passed:

  • Default config creation ✓
  • Default provider ✓
  • Default model ✓
  • Default Milvus URI ✓
  • Default collection ✓
  • Chunking defaults ✓

Part of #114

@zc277584121
Copy link
Copy Markdown
Collaborator

The config validation idea has some value, but a few things:

  • Check if these overlap with the existing tests/test_config.py.
  • test_config_default_model asserts against DEFAULT_MODELS["openai"] directly rather than the config object's resolved model — fix the assertion target.
  • Remove unused import pytest and the duplicate test_cli_help.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants