feat(search): add source_prefix filter to scope results by directory#180
Closed
haosenwang1018 wants to merge 1 commit intozilliztech:mainfrom
Closed
feat(search): add source_prefix filter to scope results by directory#180haosenwang1018 wants to merge 1 commit intozilliztech:mainfrom
haosenwang1018 wants to merge 1 commit intozilliztech:mainfrom
Conversation
zc277584121
added a commit
to zc277584121/memsearch
that referenced
this pull request
Mar 31, 2026
Add source_prefix parameter to MemSearch.search() and --source-prefix CLI option. When set, only chunks whose source path starts with the given prefix are returned, using Milvus filter expressions. Closes zilliztech#178 Supersedes zilliztech#180 zilliztech#182 Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
3 tasks
Collaborator
|
Superseded by #264 which implements the same feature with a simpler approach. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_prefixparameter toMemSearch.search()source like "<prefix>%")Why
This enables searching within a specific subdirectory without creating separate MemSearch instances, matching the request in #178.
Validation
PYTHONPATH=src python -m pytest -q tests/test_core_search_filters.pyCloses #178