fix(chain): generate v6 transactions in NU6.3+ arbitrary strategies

.cargo/config.toml

@@ -1,85 +1,5 @@
 # Zebra cargo configuration
 
-# Flags that apply to all Zebra crates and configurations
-[target.'cfg(all())']
-rustflags = [
-    # Zebra standard lints for Rust 1.65+
-
-    # High-risk code
-    "-Dunsafe_code",
-    "-Dnon_ascii_idents",
-
-    # Potential bugs
-    #
-    # If we deny these lints, we could be excluded from Crater builds:
-    # https://www.reddit.com/r/rust/comments/f5xpib/psa_denywarnings_is_actively_harmful/
-
-    # Compatibility
-    "-Wrust_2021_compatibility",
-    "-Wnonstandard_style",
-    "-Wfuture_incompatible",
-
-    # Async code
-    "-Wclippy::await_holding_lock",
-    "-Wclippy::await_holding_refcell_ref",
-
-    # Pointers
-    "-Wclippy::cast_ptr_alignment",
-    "-Wclippy::fn_to_numeric_cast_any",
-
-    # Integers
-    "-Wclippy::checked_conversions",
-    "-Wclippy::implicit_saturating_sub",
-    "-Wclippy::invalid_upcast_comparisons",
-    "-Wclippy::range_minus_one",
-    "-Wclippy::range_plus_one",
-    "-Wclippy::unnecessary_cast",
-
-    # Incomplete code
-    "-Wclippy::dbg_macro",
-    "-Wclippy::todo",
-
-    # Manual debugging output.
-    # Use tracing::trace!() or tracing::debug!() instead.
-    "-Wclippy::print_stdout",
-    "-Wclippy::print_stderr",
-    "-Wclippy::dbg_macro",
-
-    # Code styles we want to accept
-    "-Aclippy::try_err",
-
-    # Panics
-    "-Wclippy::fallible_impl_from",
-    "-Wclippy::unwrap_in_result",
-
-    # Documentation
-    "-Wmissing_docs",
-
-    # TODOs:
-    # Fix this lint eventually.
-    "-Aclippy::result_large_err",
-
-    # `cargo fix` might help do these fixes,
-    # or add a config.toml to sub-directories which should allow these lints,
-    # or try allowing the lint in the specific module (lib.rs doesn't seem to work in some cases)
-    #
-    # lint configs that don't work:
-    # - allowing these lints in lib.rs (command-line warn overrides allow in lib.rs?)
-    # - adding a [target.'cfg(not(test))'] rustflags config (it runs on test code anyway)
-
-    # fix code that triggers these lints,
-    # or disable the lint for that code (or for all test code)
-    #
-    #"-Wclippy::cast_lossless", # 30 non-test warnings, a few test warnings
-    #"-Wclippy::cast_possible_truncation", # 40 non-test warnings, 20 test warnings
-    #"-Wclippy::cast_possible_wrap", # 13 test warnings (fixed outside tests)
-    #"-Wclippy::cast_precision_loss", # 25 non-test warnings, 10 test warnings
-    #"-Wclippy::cast_sign_loss", # 6 non-test warnings, 15 test warnings
-
-    # fix hidden lifetime parameters
-    #"-Wrust_2018_idioms",
-]
-
 [build]
 rustdocflags = [
     # The -A and -W settings must be the same as the `RUSTDOCFLAGS` in:
@@ -91,3 +11,7 @@ rustdocflags = [
 
 [env]
 RUST_BACKTRACE="1"
+
+[profile.profiling]
+inherits = "release"
+debug = true

.codespellrc

@@ -1,4 +1,4 @@
 [codespell]
-ignore-words-list = crate,Sur,inout,Groth,groth,re-use,abl,
+ignore-words-list = crate,Sur,inout,Groth,groth,re-use,abl,zcash,zcashd,zebrad,zebra,utxo,utxos,nullifier,nullifiers,sapling,orchard,sprout,backpressure,proptest,thiserror,rocksdb,libsecp,fullnode,peerset,threadsafe,unrepresentable,getblocktemplate,syncer,Actix,Akka,mermaid,println,eprintln,usize,nocapture,Parallelizable,invis,UTXO,Zcash,Zaino,Zallet,librustzcash,Mainnet,Testnet,mainnet,testnet,idents,reentrancy,serializable,deserializable,deserialization,zkSNARK,zkSNARKs,lightwalletd,statics,ser,endianity,aranges,intoto
 exclude-file = book/mermaid.min.js
-skip = ./zebra-rpc/qa/rpc-tests,./supply-chain
+skip = ./zebra-rpc/qa/rpc-tests,./supply-chain,./target

.config/nextest.toml

@@ -1,132 +1,105 @@
 # Nextest configuration for Zebra
-# This file centralizes all test execution configuration.
+#
+# Profiles:
+#   default       Local dev: runs unit + integration (excludes stateful + e2e)
+#   ci            PR CI: same scope, CI-tuned output
+#   ci-stateful   GCP: runs stateful tests selected by --filter-expr
+#   ci-e2e        GCP: runs E2E tests selected by --filter-expr
+#   check-no-git-dependencies  Special CI release check
 
 [profile.default]
 fail-fast = true
 status-level = "pass"
+default-filter = 'not test(/^stateful::/) and not test(/^e2e::/) and not test(=unit::end_of_support::check_no_git_dependencies)'
 
-# --- Platform-specific overrides ---
-
-# Skip Windows-incompatible tests
-[[profile.default.overrides]]
-platform = 'cfg(target_os = "windows")'
-
-filter = "not test(=trusted_chain_sync_handles_forks_correctly) and not test(=delete_old_databases)"
+# --- CI Profile (PRs) ---
 
-# --- All Tests profile ---
-# CI-friendly test selection.
-#
-# Runs fast unit/integration tests and explicitly excludes:
-# - 'check_no_git_dependencies' (it has its own profile)
-# - stateful or long-running tests that require a local cache dir or external
-#   services (lightwalletd RPC/GRPC, full sync, checkpoint generation, mining
-#   RPCs, etc.).
-#
-# Notes:
-# - CI now provides a default cache directory, so stateful tests are no longer
-#   auto-skipped when the cache dir is undefined. To keep this profile fast and
-#   deterministic, we exclude those tests here and offer dedicated profiles
-#   below for running them when needed.
-# TODO: We need a better test architecture to run all non-stateful
-[profile.all-tests]
+[profile.ci]
+fail-fast = false
+failure-output = "immediate"
+slow-timeout = { period = "5m", terminate-after = 4 }
+default-filter = 'not test(/^stateful::/) and not test(/^e2e::/) and not test(=unit::end_of_support::check_no_git_dependencies)'
+
+[[profile.ci.overrides]]
+filter = 'test(=integration::network::disconnects_from_misbehaving_peers)'
+retries = 2
+slow-timeout = { period = "5m", terminate-after = 2 }
+
+# These tests sync mainnet to genesis from live peers; they normally finish in
+# ~10-30s, but a slow/unreachable peer can stall them. Fail fast after 10m and
+# retry instead of hanging near the old 30m hard limit, where they flaked.
+[[profile.ci.overrides]]
+filter = 'test(=integration::sync::sync_one_checkpoint_mainnet) or test(=integration::sync::restart_stop_at_height)'
+slow-timeout = { period = "5m", terminate-after = 2 }
+retries = 2
+
+[[profile.ci.overrides]]
+filter = "test(=peer_set::set::tests::vectors::peer_set_ready_multiple_connections) or test(=peer_set::set::tests::vectors::peer_set_ready_single_connection) or test(=peer_set::set::tests::vectors::peer_set_rejects_connections_past_per_ip_limit) or test(=peer_set::set::tests::vectors::peer_set_route_inv_advertised_registry)"
+retries = 2
+slow-timeout = { period = "30s", terminate-after = 2 }
+
+# --- CI Stateful Profile (GCP VMs) ---
+# CI selects specific tests via --filter-expr / NEXTEST_FILTER. The scoped
+# default filter prevents accidental whole-workspace runs in manual invocations.
+
+[profile.ci-stateful]
+fail-fast = false
 failure-output = "immediate"
-default-filter = "not test(check_no_git_dependencies) and not test(=fully_synced_rpc_z_getsubtreesbyindex_snapshot_test) and not test(=lwd_rpc_test) and not test(=lwd_rpc_send_tx) and not test(=lwd_grpc_wallet) and not test(=lwd_integration) and not test(=lwd_sync_full) and not test(=lwd_sync_update) and not test(=lightwalletd_test_suite) and not test(=rpc_get_block_template) and not test(=rpc_submit_block) and not test(=get_peer_info) and not test(~generate_checkpoints_) and not test(=sync_update_mainnet) and not test(=activate_mempool_mainnet)"
-
-# --- Individual Test Profiles ---
-
-[profile.check-no-git-dependencies]
-default-filter = 'test(check_no_git_dependencies)'
-
-[profile.sync-large-checkpoints-empty]
-slow-timeout = { period = "60m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=sync_large_checkpoints_empty)'
-
-[profile.sync-full-mainnet]
-slow-timeout = { period = "30000m", terminate-after = 1 }
 success-output = "immediate"
-default-filter = 'package(zebrad) and test(=sync_full_mainnet)'
+default-filter = 'test(/^stateful::/)'
+# Default hard timeout for stateful tests; longer-running tests override it below.
+slow-timeout = { period = "30m", terminate-after = 2 }
 
-[profile.sync-full-testnet]
-slow-timeout = { period = "1500m", terminate-after = 1 }
-success-output = "immediate"
-default-filter = 'package(zebrad) and test(=sync_full_testnet)'
+[test-groups]
+serial-state = { max-threads = 1 }
 
-[profile.sync-to-mandatory-checkpoint-mainnet]
-slow-timeout = { period = "1500m", terminate-after = 1 }
-success-output = "immediate"
-default-filter = 'package(zebrad) and test(=sync_to_mandatory_checkpoint_mainnet)'
+# Stateful tests share on-disk state, so run them serially. This override sets
+# only the test-group: adding slow-timeout here would shadow every per-test
+# timeout below, since nextest applies the first matching override per setting.
+[[profile.ci-stateful.overrides]]
+filter = 'test(/^stateful::/)'
+test-group = 'serial-state'
 
-[profile.sync-to-mandatory-checkpoint-testnet]
+[[profile.ci-stateful.overrides]]
+filter = 'test(=stateful::sync::sync_to_mandatory_checkpoint_mainnet) or test(=stateful::sync::sync_to_mandatory_checkpoint_testnet)'
 slow-timeout = { period = "1500m", terminate-after = 1 }
-success-output = "immediate"
-default-filter = 'package(zebrad) and test(=sync_to_mandatory_checkpoint_testnet)'
-
-[profile.sync-update-mainnet]
-slow-timeout = { period = "30m", terminate-after = 2 }
-success-output = "immediate"
-default-filter = 'package(zebrad) and test(=sync_update_mainnet)'
 
-[profile.sync-past-mandatory-checkpoint-mainnet]
+[[profile.ci-stateful.overrides]]
+filter = 'test(=stateful::sync::sync_past_mandatory_checkpoint_mainnet) or test(=stateful::sync::sync_past_mandatory_checkpoint_testnet) or test(=stateful::rpc::rpc_get_block_from_cached_state) or test(=stateful::lightwalletd::lightwalletd_test_suite) or test(=stateful::lightwalletd::lwd_grpc_wallet)'
 slow-timeout = { period = "60m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=sync_past_mandatory_checkpoint_mainnet)'
 
-[profile.sync-past-mandatory-checkpoint-testnet]
-slow-timeout = { period = "60m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=sync_past_mandatory_checkpoint_testnet)'
+# --- CI E2E Profile (GCP VMs) ---
+# CI selects specific tests via --filter-expr / NEXTEST_FILTER. The scoped
+# default filter prevents accidental whole-workspace runs in manual invocations.
 
-[profile.generate-checkpoints-mainnet]
-slow-timeout = { period = "90m", terminate-after = 1 }
-success-output = "immediate"
-default-filter = 'package(zebrad) and test(=generate_checkpoints_mainnet)'
-
-[profile.generate-checkpoints-testnet]
-slow-timeout = { period = "90m", terminate-after = 1 }
+[profile.ci-e2e]
+fail-fast = false
+failure-output = "immediate"
 success-output = "immediate"
-default-filter = 'package(zebrad) and test(=generate_checkpoints_testnet)'
-
-[profile.lwd-rpc-test]
-test-threads = 1
+default-filter = 'test(/^e2e::/)'
+# Default hard timeout for e2e tests; longer-running tests override it below.
 slow-timeout = { period = "60m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=lwd_rpc_test)'
 
-[profile.lwd-integration]
-slow-timeout = { period = "30m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=lwd_integration)'
+# E2e tests share on-disk state, so run them serially. This override sets only
+# the test-group: adding slow-timeout here would shadow every per-test timeout
+# below, since nextest applies the first matching override per setting.
+[[profile.ci-e2e.overrides]]
+filter = 'test(/^e2e::/)'
+test-group = 'serial-state'
 
-[profile.lwd-sync-full]
+[[profile.ci-e2e.overrides]]
+filter = 'test(=e2e::sync::sync_full_mainnet) or test(=e2e::lightwalletd::lwd_sync_full)'
 slow-timeout = { period = "30000m", terminate-after = 1 }
-success-output = "immediate"
-default-filter = 'package(zebrad) and test(=lwd_sync_full)'
-
-[profile.lwd-sync-update]
-slow-timeout = { period = "30m", terminate-after = 2 }
-success-output = "immediate"
-default-filter = 'package(zebrad) and test(=lwd_sync_update)'
-
-[profile.lwd-grpc-wallet]
-slow-timeout = { period = "60m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=lwd_grpc_wallet)'
 
-[profile.lwd-rpc-send-tx]
-slow-timeout = { period = "30m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=lwd_rpc_send_tx)'
-
-[profile.rpc-get-block-template]
-slow-timeout = { period = "30m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=rpc_get_block_template)'
-
-[profile.rpc-submit-block]
-slow-timeout = { period = "30m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=rpc_submit_block)'
+[[profile.ci-e2e.overrides]]
+filter = 'test(=e2e::sync::sync_full_testnet)'
+slow-timeout = { period = "1500m", terminate-after = 1 }
 
-[profile.indexer-has-spending-transaction-ids]
-slow-timeout = { period = "30m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=has_spending_transaction_ids)'
+[[profile.ci-e2e.overrides]]
+filter = 'test(=e2e::checkpoints::generate_checkpoints_mainnet) or test(=e2e::checkpoints::generate_checkpoints_testnet)'
+slow-timeout = { period = "90m", terminate-after = 1 }
 
-[profile.lightwalletd-test-suite]
-slow-timeout = { period = "60m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=lightwalletd_test_suite)'
+# --- Special Profile ---
 
-[profile.rpc-z-getsubtreesbyindex-snapshot]
-slow-timeout = { period = "30m", terminate-after = 2 }
-default-filter = 'package(zebrad) and test(=fully_synced_rpc_z_getsubtreesbyindex_snapshot_test)'
+[profile.check-no-git-dependencies]
+default-filter = 'test(=unit::end_of_support::check_no_git_dependencies)'

.dockerignore

@@ -12,6 +12,10 @@
 #
 *
 
+# Keep `.git` out of the context (do NOT add `!.git`). The binary takes its commit
+# from the SHORT_SHA build arg; including .git makes the build depend on clone shape.
+# See docs/decisions/devops/0007-reproducible-builds.md.
+
 # Now un-exclude required files and folders:
 #
 !.cargo

.github/CODEOWNERS

@@ -2,7 +2,7 @@
 # this team will be requested for review when someone opens a pull request.
 #
 # We use a single team here, because if we use two teams, GitHub assigns two reviewers.
-*                                       @ZcashFoundation/general-rust-reviewers
+# *                                       @ZcashFoundation/general-rust-reviewers
 
 # Frequently Modified Code
 #
@@ -11,36 +11,36 @@
 # to stop GitHub assigning multiple reviewers
 #
 # lightwalletd epic
-/zebrad/src/commands/start.rs           @ZcashFoundation/general-rust-reviewers
+# /zebrad/src/commands/start.rs           @ZcashFoundation/general-rust-reviewers
 
 # Network and Async Code
-/tower-batch-control/                   @ZcashFoundation/network-reviewers
-/tower-fallback/                        @ZcashFoundation/network-reviewers
-/zebra-network/                         @ZcashFoundation/network-reviewers
-/zebra-node-services/                   @ZcashFoundation/network-reviewers
-/zebra-tests/src/mock_service.rs        @ZcashFoundation/network-reviewers
-/zebra-tests/src/service_extensions.rs  @ZcashFoundation/network-reviewers
-/zebra-tests/src/transcript.rs          @ZcashFoundation/network-reviewers
-/zebrad/src/components/                 @ZcashFoundation/network-reviewers
+# /tower-batch-control/                   @ZcashFoundation/network-reviewers
+# /tower-fallback/                        @ZcashFoundation/network-reviewers
+# /zebra-network/                         @ZcashFoundation/network-reviewers
+# /zebra-node-services/                   @ZcashFoundation/network-reviewers
+# /zebra-tests/src/mock_service.rs        @ZcashFoundation/network-reviewers
+# /zebra-tests/src/service_extensions.rs  @ZcashFoundation/network-reviewers
+# /zebra-tests/src/transcript.rs          @ZcashFoundation/network-reviewers
+# /zebrad/src/components/                 @ZcashFoundation/network-reviewers
 
 # Cryptographic Code
-/zebra-consensus/src/primitives/        @ZcashFoundation/cryptographic-reviewers
-/zebra-chain/src/primitives/            @ZcashFoundation/cryptographic-reviewers
-/zebra-chain/src/orchard/               @ZcashFoundation/cryptographic-reviewers
-/zebra-chain/src/sapling/               @ZcashFoundation/cryptographic-reviewers
-/zebra-chain/src/sprout/                @ZcashFoundation/cryptographic-reviewers
-/zebra-chain/src/transparent/           @ZcashFoundation/cryptographic-reviewers
-/zebra-chain/src/history_tree.rs        @ZcashFoundation/cryptographic-reviewers
-/zebra-chain/src/history_tree/          @ZcashFoundation/cryptographic-reviewers
+# /zebra-consensus/src/primitives/        @ZcashFoundation/cryptographic-reviewers
+# /zebra-chain/src/primitives/            @ZcashFoundation/cryptographic-reviewers
+# /zebra-chain/src/orchard/               @ZcashFoundation/cryptographic-reviewers
+# /zebra-chain/src/sapling/               @ZcashFoundation/cryptographic-reviewers
+# /zebra-chain/src/sprout/                @ZcashFoundation/cryptographic-reviewers
+# /zebra-chain/src/transparent/           @ZcashFoundation/cryptographic-reviewers
+# /zebra-chain/src/history_tree.rs        @ZcashFoundation/cryptographic-reviewers
+# /zebra-chain/src/history_tree/          @ZcashFoundation/cryptographic-reviewers
 
 # Devops Code
-/.github/workflows/                     @ZcashFoundation/devops-reviewers
-/.github/mergify.yml                    @ZcashFoundation/devops-reviewers
-/docker/                                @ZcashFoundation/devops-reviewers
-cloudbuild.yaml                         @ZcashFoundation/devops-reviewers
-codecov.yml                             @ZcashFoundation/devops-reviewers
-firebase.json                           @ZcashFoundation/devops-reviewers
-katex-header.html                       @ZcashFoundation/devops-reviewers
+# /.github/workflows/                     @ZcashFoundation/devops-reviewers
+# /.github/mergify.yml                    @ZcashFoundation/devops-reviewers
+# /docker/                                @ZcashFoundation/devops-reviewers
+# cloudbuild.yaml                         @ZcashFoundation/devops-reviewers
+# codecov.yml                             @ZcashFoundation/devops-reviewers
+# firebase.json                           @ZcashFoundation/devops-reviewers
+# katex-header.html                       @ZcashFoundation/devops-reviewers
 
 # Unsafe Code
-/zebra-script/                          @ZcashFoundation/unsafe-rust-reviewers
+# /zebra-script/                          @ZcashFoundation/unsafe-rust-reviewers