Move read sync code into sync submodule#134
Merged
Pr0methean merged 13 commits intozip-rs:sync-asyncfrom May 18, 2024
Merged
Conversation
SapryWenInera
changed the title
Member
|
I changed the target branch of this PR, because it moves some public methods and therefore requires a version 2.0.0 before it can be released. I'll set #121 to target this branch as well, and then we can merge into master once everything's finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pr to avoid merge conflicts for master with #121. This adds no feature but it moves much of the code of read.rs into a sync submodule.