feat: Increase MSRV to 1.88 and update dependencies#626
feat: Increase MSRV to 1.88 and update dependencies#626Pr0methean wants to merge 12 commits intomasterfrom
Conversation
…pendency updates that have a higher MSRV
Summary of ChangesHello @Pr0methean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's dependency management strategy by enabling Cargo's Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Review Summary
This PR adds resolver = "3" and updates dependency versions to allow newer versions with higher MSRV. However, there are critical issues that block merging:
Critical Issues Found:
-
Build Error: Cargo resolver "3" requires Rust edition 2024, but the package uses edition "2021". This will cause immediate build failure.
-
Inconsistent
timedependency version: The main[dependencies]section at line 44 still usestime = { version = "=0.3.45", ...}with an exact pin, while the target-specific and dev-dependencies were updated to^0.3.45. This inconsistency means Cargo will enforce the exact version throughout, defeating the purpose of this PR. The main dependency declaration must also be updated to^0.3.45.
Recommendation:
Please fix both critical issues before merging. The resolver should be set to "2" (compatible with edition 2021), or the edition should be upgraded to 2024. Additionally, ensure all time dependency declarations consistently use ^0.3.45.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request updates the Cargo.toml to use a newer dependency resolver and relaxes version constraints for several dependencies. However, it sets the resolver version to "3", which is invalid. The correct value for the Rust-version-aware resolver is "2". I've added a comment to correct this. The other dependency updates seem appropriate for the stated goal of enabling updates with higher MSRV.
…me> for FileTime`, so use UtcDateTime instead
* feat: Switch to Rust-version-aware dependency resolver, and enable dependency updates that have a higher MSRV * Fix: unpin `time` in main dependency section * Fix: bump MSRV to 1.85 to enable resolver 3 * Make `time` feature explicit * Don't need time/wasm-bindgen on non-wasm targets * Fix: need to use 1.85.0, not 1.85.1, for MSRV test * Fix: use >= rather than ^ for time version * Fix: replace other instances of ^0.3.45 with >=0.3.45 for time version * Fix? use bare "0.3.45" for time version * Fix: increase MSRV to 1.88 to work around cargo resolver limitations * Fix? Remove duplicate dependency entry for `time` * Fix: newer `nt_time` version doesn't `impl TryInto<time::OffsetDateTime> for FileTime`, so use UtcDateTime instead
Fixes #621.