Skip to content

fix job-output path handling - #403

Open
ATorrise wants to merge 5 commits into
mainfrom
backtracking
Open

fix job-output path handling #403
ATorrise wants to merge 5 commits into
mainfrom
backtracking

Conversation

@ATorrise

@ATorrise ATorrise commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

What It Does

  • Fixes get_job_output_as_files which was writing to a folder it never created and crashing with FNF
  • Builds the output paths so they match the folders the method actually makes
  • Checks job values from the response before using them as folder names
  • Rejects any name with .. in it (team discussion request)
  • Rejects any name that is an absolute path (team discussion request)
  • Makes sure the final file path stays inside the output folder

How to Test

Review Checklist
I certify that I have:

  • updated the changelog
  • manually tested my changes
  • added/updated automated unit/integration tests
  • created/ran system tests (provide build number if applicable)
  • followed the contribution guidelines

Additional Comments

Signed-off-by: Amber Torrise <ambertorrise@gmail.com>
@github-project-automation github-project-automation Bot moved this to New Issues in Zowe CLI Squad Jul 28, 2026
@zowe-robot zowe-robot moved this from New Issues to In Progress in Zowe CLI Squad Jul 28, 2026
ATorrise added 2 commits July 28, 2026 15:26
Signed-off-by: Amber Torrise <ambertorrise@gmail.com>
…parent dir

Signed-off-by: Amber Torrise <ambertorrise@gmail.com>
@ATorrise ATorrise changed the title method porting fix path handling Jul 28, 2026
@ATorrise ATorrise changed the title fix path handling fix job-output path handling Jul 28, 2026
@ATorrise
ATorrise marked this pull request as ready for review July 28, 2026 19:39
@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe CLI Squad Jul 28, 2026
ATorrise added 2 commits July 28, 2026 15:41
Signed-off-by: Amber Torrise <ambertorrise@gmail.com>
Signed-off-by: Amber Torrise <ambertorrise@gmail.com>
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.89%. Comparing base (096a095) to head (351ba77).

Files with missing lines Patch % Lines
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py 88.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   82.11%   82.89%   +0.78%     
==========================================
  Files          49       49              
  Lines        2919     2947      +28     
==========================================
+ Hits         2397     2443      +46     
+ Misses        522      504      -18     
Flag Coverage Δ
unittests 82.89% <88.23%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review/QA

Development

Successfully merging this pull request may close these issues.

2 participants