Replace flatdict with a helper implementation#453
Closed
enza252 wants to merge 1 commit intozscaler:masterfrom
Closed
Replace flatdict with a helper implementation#453enza252 wants to merge 1 commit intozscaler:masterfrom
enza252 wants to merge 1 commit intozscaler:masterfrom
Conversation
* `flatdict`is an old package which has not received an update or release in nearly 6 years by this point * The flatdict dependence on an old version of setuptools is causing build errors in downstream projects. * Since this project loosely depends on flatdict, this seems like a quick win to remove the dependence of an old package, and eliminate setuptools build errors * These changes were co-written with Claude, so all scrutinty is warranted and appreciated.
f1b224c to
9c57bad
Compare
Member
|
Hi @enza252 , thank you for taking the time to report this issue and submit a PR — we really appreciate it! We've addressed this in #457, which replaces flatdict with internal flatten_dict/unflatten_dict helpers (same approach you proposed). Your contribution is credited in the changelog and release notes. Zscaler DevRel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
flatdictis an old package which has not received an update or release in nearly 6 years by this pointExample stack trace from trying to install
zscaler-sdk-pythonwithflatdict:Has your change been tested?
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
I appreciate that your CONTRIBUTING docs state that you are not welcoming contributions, however, as a large ZScaler customer, this a pain point for us, and we would appreciate your support in this.