fix: replace unmaintained flatdict with internal implementation#455
Closed
pankaj28843 wants to merge 1 commit intozscaler:masterfrom
Closed
fix: replace unmaintained flatdict with internal implementation#455pankaj28843 wants to merge 1 commit intozscaler:masterfrom
pankaj28843 wants to merge 1 commit intozscaler:masterfrom
Conversation
flatdict 4.0.1 uses pkg_resources which was removed in setuptools 82. Add minimal FlatDict to utils.py with same API for SDK usage. Remove flatdict from dependencies. Fixes build with pip 25+ and setuptools 82+.
pankaj28843
force-pushed
the
fix/remove-flatdict-dependency
branch
from
d5f0998 to
635bf50
Compare
willguibr
added
🐛 type/bug
Member
|
Hi @pankaj28843 , thank you for taking the time to report this issue and submit a PR — we really appreciate it! We've addressed this in #457, which replaces flatdict with internal flatten_dict/unflatten_dict helpers (same approach you proposed). Your contribution is credited in the changelog and release notes. Zscaler DevRel |
github-project-automation
bot
moved this from ⚙️ In development
to 🚀 Shipped
in Zscaler Automation Dashboard 🛣
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces flatdict with internal FlatDict implementation.
Problem
flatdict 4.0.1 (last release Feb 2020) uses
pkg_resourcesin setup.py.setuptools 82+ removed
pkg_resources, breaking pip install.Changes
zscaler/utils.pyconfig_setter.pyTesting
All 450 unit tests pass.
Fixes #454