Fix 0.25 deprecations (and 0.26 errors). Fix the iOS warning. Fix logic bugs due properties being set in nondeterminstic orders.#8
Open
mikelambert wants to merge 5 commits intozzyyppqq:masterfrom
Conversation
…n warning due to the missing native module. This separates it out into a separate per-platform files to avoid the warning.
…rty in any order. But most properties only make sense to set *after* setting childText. This ensures that the views get updated and reflected, no matter what order they are set in.
Author
|
Added another change to this, and updating the title to reflect it. Bugs were:
This third changelist fixes all of those issues. |
Author
|
Ping? |
|
@mikelambert When running your fork, I've got |
Author
|
What version of RN are you using? RN changed their API for Event constructors as of 0.32 (due to the breaking change for android listed in https://github.com/facebook/react-native/releases/tag/v0.32.0), and this pull request now (with 1a8c1ef) fixes that for react-native-segmented-android as well. So this change is only compatible with 0.32 and up. |
|
Hi @mikelambert You right. I'll update my project and let you know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.