Add activity_id column to temporal transfers #2347
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Implements deposit workflow pattern to eliminate transfer activity race conditions. The activity_id column tracks pending activities created by the temporal trigger, enabling the indexer to directly delete them using the activity_id reference instead of querying by event_id/event_name. Test plan: - Apply migration: supabase db push Expected: activity_id column added with index and FK - Verify schema: supabase db diff Expected: no differences between migration and schema file - Check constraint: \d temporal.send_account_transfers Expected: fk_transfer_activity FK to public.activity(id)
Collaborator
Author
This was referenced Dec 19, 2025
|
Vercel Unique URL: https://sendapp-66k2e9m4x-0xsend.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Implements deposit workflow pattern to eliminate transfer activity
race conditions. The activity_id column tracks pending activities
created by the temporal trigger, enabling the indexer to directly
delete them using the activity_id reference instead of querying
by event_id/event_name.
Test plan:
Expected: activity_id column added with index and FK
Expected: no differences between migration and schema file
Expected: fk_transfer_activity FK to public.activity(id)