Fix frontend activity feed race conditions and optimistic updates #2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Fixes critical race conditions in the activity feed by: 1) updating optimistic entry event_id to match workflowId after transfer succeeds (prevents duplicates when temporal activity arrives), 2) removing optimistic entry on transfer failure (prevents stale entries), 3) optimizing polling to only poll 'initialized', 'submitted', 'sent' statuses (not 'confirmed'), 4) adding user_op_hash to optimistic entries, 5) documenting asymmetric filtering where recipients don't see temporal activities. Test plan: - Build project: npm run build Expected: No TypeScript errors - Start transfer and watch activity feed Expected: Only one activity appears (no duplicate when temporal arrives) - Force transfer failure before workflow starts Expected: Optimistic entry removed from feed - Monitor network during confirmed transfer Expected: Polling stops after status becomes 'confirmed'
This was referenced Dec 19, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Fixes critical race conditions in the activity feed by: 1) updating
optimistic entry event_id to match workflowId after transfer succeeds
(prevents duplicates when temporal activity arrives), 2) removing
optimistic entry on transfer failure (prevents stale entries), 3)
optimizing polling to only poll 'initialized', 'submitted', 'sent'
statuses (not 'confirmed'), 4) adding user_op_hash to optimistic
entries, 5) documenting asymmetric filtering where recipients don't
see temporal activities.
Test plan:
Expected: No TypeScript errors
Expected: Only one activity appears (no duplicate when temporal arrives)
Expected: Optimistic entry removed from feed
Expected: Polling stops after status becomes 'confirmed'