Prevent ACE guns from hitting their own contraptions#302
Open
Ally-for-Hire wants to merge 3 commits into
Open
Conversation
Ally-for-Hire
marked this pull request as draft
July 23, 2026 01:46
Ally-for-Hire
marked this pull request as ready for review
July 24, 2026 01:48
Collaborator
Author
|
works ingame, i approve for merge, will wait a few days |
Ally-for-Hire
commented
Jul 24, 2026
Ally-for-Hire
left a comment
Collaborator
Author
There was a problem hiding this comment.
code looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea
Look into how ACF-3 does their self-filtering, port that as it applies, and remove legacy fixes that would manually offset the bullets. We can use AI to find the specifics as they pertain to ACE, and then we can create an implementation plan for it to execute.
Description
ACE projectile filters previously excluded only the firing gun, so moving-shot traceback could re-enter the firing vehicle and damage its own armor. This ports ACF-3's contraption-wide projectile filtering approach and corrects ACE's projectile-origin handling. We are diverging slightly from theirs by implementing a 3 tick grace window, then back to normal function, so bullet's can still hit your vehicle after they've left it.
Summary