Port as much of ACE as possible to ACE. namespace#307
Open
Ally-for-Hire wants to merge 61 commits into
Open
Conversation
Collaborator
Author
|
holy git diff 😭 , not much i can do about it without reverting functionality. what it does really does just touch SO many files and functions |
ACE. namespace
Member
Collaborator
Author
|
that was addressed and fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Idea
This is a pretty major refactor, continuing on the previous one of internal-function namespaces, this targets the remaining hooks and cvars left from ACF2. We can use AI to identify legacy functions and namespace incompatibilities and monitor the resolution. The scope and implementation of the work was designed by the team itself.
Description
This refactor will finish converting the namespaces to a consistent
ACE.andACE_rather than the variousACF.,ACF_, orACE_with very little rhyme or reason found through the code. A previous PR already fixed most of the internal functions, and this one is scoped to finding and resolving all of the rest that won't break backwards compatibility. This will mostly avoid touching player-facing behaviour and shouldn't touch optimization, it will just be the next step towards a better back-end. Previously this was split into the following categories:ACF.was used for global ACF2 and older ACE functionsACF_was used for ACF2 and older ACE specific functionsACE_andACE.were used inconsistently across newer functionsWe want to move all ACE functions to the
ACE.namespace, and move all hooks to theACE_namespace or give them unique hook IDs so they can't get overwritten or become incompatible trivially. We can also take this time to ensure all the code follows CFC's GLUA guidelines.Notes