Skip to content

IPv6 support - #9

Open
hjltu wants to merge 4 commits into
ADTRAN:mainfrom
hjltu:Add_support_for_the_IPv6_protocol_family
Open

IPv6 support#9
hjltu wants to merge 4 commits into
ADTRAN:mainfrom
hjltu:Add_support_for_the_IPv6_protocol_family

Conversation

@hjltu

@hjltu hjltu commented Jan 13, 2021

Copy link
Copy Markdown

add: all addresses support for client,
ipv6 option for callhome.

add: all addresses support for client,
    ipv6 option for callhome.

@JennToo JennToo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

There are just a few minor changes. If you prefer, I can also make them myself after merging this PR. Just let me know!

Comment thread netconf_client/connect.py Outdated
Comment thread netconf_client/connect.py
@codecov-io

codecov-io commented Jan 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #9 (68912df) into master (b776e6f) will decrease coverage by 3.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   82.11%   78.92%   -3.19%     
==========================================
  Files           8        8              
  Lines         559      579      +20     
  Branches       63       66       +3     
==========================================
- Hits          459      457       -2     
- Misses         79      101      +22     
  Partials       21       21              
Impacted Files Coverage Δ
netconf_client/connect.py 0.00% <0.00%> (ø)
netconf_client/ncclient.py 99.44% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b776e6f...68912df. Read the comment docs.

@hjltu
hjltu requested a review from wburkhardt as a code owner January 14, 2021 07:12
@hjltu

hjltu commented Jan 14, 2021

Copy link
Copy Markdown
Author

OK, you can merge it now, it's all your :)

Comment thread netconf_client/connect.py
Comment thread netconf_client/connect.py
Comment thread netconf_client/connect.py Outdated
hjltu added 2 commits January 15, 2021 10:54
Merge branch 'master' into Add_support_for_the_IPv6_protocol_family
fix: raise socket error if not connected,
    ipv6 default is False
@hjltu
hjltu force-pushed the Add_support_for_the_IPv6_protocol_family branch from d9d1f31 to d68bdc1 Compare January 15, 2021 06:24
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.92%. Comparing base (b776e6f) to head (68912df).
⚠️ Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
netconf_client/connect.py 0.00% 30 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   82.11%   78.92%   -3.19%     
==========================================
  Files           8        8              
  Lines         559      579      +20     
  Branches       63       66       +3     
==========================================
- Hits          459      457       -2     
- Misses         79      101      +22     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants