[WIP] Add support for formatting collections and handles#932
Open
tmadlener wants to merge 19 commits intoAIDASoft:masterfrom
Open
[WIP] Add support for formatting collections and handles#932tmadlener wants to merge 19 commits intoAIDASoft:masterfrom
tmadlener wants to merge 19 commits intoAIDASoft:masterfrom
Conversation
As a first step using the ostream_formatter adaptor to re-use the existing operator<<.
Implement the existing operator<< in terms of format_to
Necessary to ensure that things still compile if fmt/ranges.h is included to avoid ambiguities that would otherwise arise because LinkT behaves tuple-like enough to trigger tuple formatting. Collections are ranges so we have to explicitly opt-out.
tmadlener
changed the title
Collaborator
Author
|
Looks like fmt v12 is not really happy with this. I will continue with what I actually want to achieve and then circle back to see if we still need it in the end or whether we can solve things with |
Also get rid of some hideous string concatenation while we are at it
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
fmt::formatterfor all generated types and for the types related toLinks. Implementoperator<<in terms offormat_to.ENDRELEASENOTES
printin terms offormatostream_collection_headerfilter now that formatting can be done better with the format syntax.This PR implements the minimal feature set to "properly" support
formatting them via a custom implementation offormatter. Theoperator<<are now implemented in terms offormat_toinstead of the other way around.This is another intermediate step towards customizable formatting as outlined in #920 (comment).
A (final) follow up PR to this will implement the possibility to provide custom formatting (which will also decide whether it is truly possible to do so).