Skip to content

Conversation

@martinboulais
Copy link
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • QC flags boundaries can be null and will automatically be coalesced to run boundaries

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.72%. Comparing base (ca2c5cb) to head (87482cc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...33702-set-flag-bound-null-when-equal-to-run-end.js 54.54% 5 Missing ⚠️
...lags/qcFlagsVisualization/qcFlagsChartComponent.js 0.00% 2 Missing ⚠️
...ervices/qualityControlFlag/QcFlagSummaryService.js 96.55% 2 Missing ⚠️
...lags/ForDataPass/QcFlagsForDataPassOverviewPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
+ Coverage   44.59%   44.72%   +0.13%     
==========================================
  Files        1008     1011       +3     
  Lines       16988    17028      +40     
  Branches     3066     3066              
==========================================
+ Hits         7576     7616      +40     
  Misses       9412     9412              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

xsalonx
xsalonx previously approved these changes Mar 13, 2025
xsalonx
xsalonx previously approved these changes Mar 19, 2025
@xsalonx
Copy link
Collaborator

xsalonx commented Mar 21, 2025

Not too late 😅

@martinboulais martinboulais merged commit f09a4b8 into main Mar 28, 2025
23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1435/rework-qc-flags-storage branch March 28, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants