Skip to content

[O2B-1435] Rework QC flags storage to have nullable bounds #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinboulais merged 22 commits into from
Mar 28, 2025

Merge branch 'main' into mboulais/O2B-1435/rework-qc-flags-storage

87482cc
Select commit
Loading
Failed to load commit list.
Merged

[O2B-1435] Rework QC flags storage to have nullable bounds #1871

Merge branch 'main' into mboulais/O2B-1435/rework-qc-flags-storage
87482cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 27, 2025 in 1s

93.75% of diff hit (target 44.59%)

View this Pull Request on Codecov

93.75% of diff hit (target 44.59%)

Annotations

Check warning on line 32 in lib/database/migrations/v1/20250326133702-set-flag-bound-null-when-equal-to-run-end.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/database/migrations/v1/20250326133702-set-flag-bound-null-when-equal-to-run-end.js#L31-L32 

Added lines #L31 - L32 were not covered by tests

Check warning on line 37 in lib/database/migrations/v1/20250326133702-set-flag-bound-null-when-equal-to-run-end.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/database/migrations/v1/20250326133702-set-flag-bound-null-when-equal-to-run-end.js#L37 

Added line #L37 was not covered by tests

Check warning on line 44 in lib/database/migrations/v1/20250326133702-set-flag-bound-null-when-equal-to-run-end.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/database/migrations/v1/20250326133702-set-flag-bound-null-when-equal-to-run-end.js#L44 

Added line #L44 was not covered by tests

Check warning on line 49 in lib/database/migrations/v1/20250326133702-set-flag-bound-null-when-equal-to-run-end.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/database/migrations/v1/20250326133702-set-flag-bound-null-when-equal-to-run-end.js#L49 

Added line #L49 was not covered by tests

Check warning on line 92 in lib/public/views/QcFlags/ForDataPass/QcFlagsForDataPassOverviewPage.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/views/QcFlags/ForDataPass/QcFlagsForDataPassOverviewPage.js#L92 

Added line #L92 was not covered by tests

Check warning on line 29 in lib/public/views/QcFlags/qcFlagsVisualization/qcFlagsChartComponent.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/views/QcFlags/qcFlagsVisualization/qcFlagsChartComponent.js#L28-L29 

Added lines #L28 - L29 were not covered by tests

Check warning on line 102 in lib/server/services/qualityControlFlag/QcFlagSummaryService.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/server/services/qualityControlFlag/QcFlagSummaryService.js#L102 

Added line #L102 was not covered by tests

Check warning on line 169 in lib/server/services/qualityControlFlag/QcFlagSummaryService.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/server/services/qualityControlFlag/QcFlagSummaryService.js#L169 

Added line #L169 was not covered by tests
View more details on Codecov