Skip to content

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Aug 2, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Added VTX, MTE, EVS, CEN, EVP, GMU, MUD columns to RCT's runs' displayes

Notable changes for developers:

  • Added AOT-EVENT, AOT-GLO and MUON-GLO detector types
  • Add a one run in seeders
  • Disable checking pdpBeamType in test function navigateToRunsPerDataPass, as this parameter will be removed

Changes made to the database:

  • ObervableData supports arrays of observable data

@xsalonx xsalonx self-assigned this Aug 2, 2025
@xsalonx xsalonx added the backend label Aug 2, 2025
@xsalonx xsalonx changed the title [O2B-1317] Add AOT and MUON columns [O2B-1317] Add MUON columns Aug 4, 2025
@xsalonx xsalonx changed the title [O2B-1317] Add MUON columns [O2B-1317] Add MUON and AOT columns Aug 12, 2025
@xsalonx xsalonx changed the title [O2B-1317] Add MUON and AOT columns [O2B-1467] Add MUON and AOT columns Aug 12, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 15.38462% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.81%. Comparing base (1ebeee9) to head (f52a66b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 14 Missing ⚠️
lib/public/services/detectors/detectorsProvider.js 0.00% 10 Missing ⚠️
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 10 Missing ⚠️
lib/public/utilities/ObservableData.js 0.00% 8 Missing ⚠️
.../Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js 0.00% 3 Missing ⚠️
...1/20250901153000-allow-more-enum-detector-types.js 71.42% 2 Missing ⚠️
.../ActiveColumns/runDetectorsAsyncQcActiveColumns.js 0.00% 2 Missing ⚠️
...s/ActiveColumns/runDetectorsSyncQcActiveColumns.js 0.00% 2 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 1 Missing ⚠️
lib/public/domain/enums/DetectorTypes.js 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
- Coverage   45.85%   45.81%   -0.05%     
==========================================
  Files        1018     1019       +1     
  Lines       16825    16863      +38     
  Branches     3034     3041       +7     
==========================================
+ Hits         7715     7725      +10     
- Misses       9110     9138      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx marked this pull request as ready for review August 14, 2025 10:42
@xsalonx xsalonx requested a review from graduta as a code owner August 14, 2025 10:42
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there not be a migration file for adding those detectors as well and not just the detector types?

@xsalonx xsalonx requested a review from graduta August 19, 2025 13:24
@xsalonx xsalonx merged commit 0ce697b into main Aug 19, 2025
22 of 24 checks passed
@xsalonx xsalonx deleted the xsalonx/aot/O2B-1317/add-aot-and-muon-columns branch August 19, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants