Skip to content

wpcomsh: footer credit#48528

Closed
mgozdis wants to merge 2 commits intotrunkfrom
DOTTHEM-343-footer-credit
Closed

wpcomsh: footer credit#48528
mgozdis wants to merge 2 commits intotrunkfrom
DOTTHEM-343-footer-credit

Conversation

@mgozdis
Copy link
Copy Markdown
Contributor

@mgozdis mgozdis commented May 5, 2026

Fixes DOTTHEM-343

Proposed changes

  • Adds a word boundary to prevent improper replacement of the first instance of "theme" within a footer.php when the active theme does not follow coding standards and have a valid style.css.
  • We may want to also just early return entirely if the theme name can't be detected.

Related product discussion/links

Testing instructions

  1. Install and activate the following test theme manually via SFTP/SSH (wp-admin has guards to prevent installing a theme with invalid style.css) wp theme activate testtheme - testtheme.zip
  2. Review the footer area on the frontend and see if the screenshot.png image displays or is broken.
  3. Review the source code of the page in your browser and search for wp-content/s/ to ensure an improper string replacement hasn't been made.

Does this pull request change what data or activity we track or use?

No

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the DOTTHEM-343-footer-credit branch.

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 5, 2026
@mgozdis mgozdis added the [Status] Needs Review This PR is ready for review. label May 5, 2026
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented May 5, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@mgozdis
Copy link
Copy Markdown
Contributor Author

mgozdis commented May 6, 2026

Closing this to create a new PR instead to check for an empty theme name as this doesn't work.

@mgozdis mgozdis closed this May 6, 2026
@github-actions github-actions Bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Review This PR is ready for review. labels May 6, 2026
@mgozdis mgozdis deleted the DOTTHEM-343-footer-credit branch May 6, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant