Skip to content

wpcomsh: footer credit #48528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgozdis wants to merge 2 commits into from
+5 −1
Closed

wpcomsh: footer credit #48528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0db2ed1
Fix: Add word boundary to prevent improper empty string replacement
mgozdis May 1, 2026
1e2773e
Add changelog
mgozdis May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/wpcomsh/changelog/DOTTHEM-343-footer-credit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Added word boundary to prevent replacing first instance of the word theme with an empty string when a theme doesn't have a valid style.css
2 changes: 1 addition & 1 deletion projects/plugins/wpcomsh/footer-credit/footer-credit-optimizations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function wpcom_better_footer_links( $footer ) {
$theme_regex = array(
'(?:\s*\|\s*)?', // Optional pipe with spaces (non-capturing)
'(?:<span\s[^>]+>)?', // Optional opening span tag (non-capturing)
'(Theme|%s)', // $1: "Theme" or the localized equivalent
'(\bTheme\b|%s)', // $1: "Theme" or the localized equivalent (word boundaries prevent partial match)
'\s*(?:&nbsp;)?:?\s*', // Zero or more whitespace characters, an optional colon, zero or more whitespace characters
'(%s|<a[^>]+>%s</a>)', // $2: The theme name, or link
'\.?', // Optional period
Expand Down