MSI POP Attestation #5612
Open
MSI POP Attestation #5612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
reviewed
Dec 8, 2025
src/client/Microsoft.Identity.Client.MtlsPop/ManagedIdentityPopExtensions.cs
Outdated
Show resolved
Hide resolved
...ent/Microsoft.Identity.Client.KeyAttestation/Microsoft.Identity.Client.KeyAttestation.csproj
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/V2/ImdsV2ManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Dec 11, 2025
bgavrilMS
reviewed
Dec 11, 2025
src/client/Microsoft.Identity.Client.KeyAttestation/AttestationClient.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Dec 11, 2025
src/client/Microsoft.Identity.Client.KeyAttestation/AttestationStatus.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Dec 11, 2025
src/client/Microsoft.Identity.Client.KeyAttestation/ManagedIdentityAttestationExtensions.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Dec 11, 2025
| <Version>$(MicrosoftIdentityClientVersion)-preview</Version> | ||
| <!-- Copyright needs to be in the form of © not (c) to be compliant --> | ||
| <Title>MSAL.NET extension for managed identity proof-of-possession flows</Title> | ||
| <Title>MSAL.NET extension for KeyGuard attestation support</Title> |
Contributor
There was a problem hiding this comment.
the feature GA'd under this name - https://learn.microsoft.com/en-us/windows/security/identity-protection/credential-guard/
Contributor
Author
There was a problem hiding this comment.
What action do you want me to take here? CC @bgavrilMS
Member
There was a problem hiding this comment.
All comments should refer to this as Credential Guard.
...ent/Microsoft.Identity.Client.KeyAttestation/Microsoft.Identity.Client.KeyAttestation.csproj
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client.KeyAttestation/PopKeyAttestor.cs
Outdated
Show resolved
Hide resolved
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\client\Microsoft.Identity.Client\Microsoft.Identity.Client.csproj" /> | ||
| <ProjectReference Include="..\..\src\client\Microsoft.Identity.Client.MtlsPop\Microsoft.Identity.Client.MtlsPop.csproj" /> | ||
| <ProjectReference Include="..\..\src\client\Microsoft.Identity.Client.KeyAttestation\Microsoft.Identity.Client.KeyAttestation.csproj" /> |
Contributor
There was a problem hiding this comment.
we may also need to fix the OneBranch release pipeline and update the project name
gladjohn
reviewed
Dec 11, 2025
src/client/Microsoft.Identity.Client.KeyAttestation/AttestationResult.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Dec 12, 2025
src/client/Microsoft.Identity.Client.KeyAttestation/PublicAPI/net8.0/PublicAPI.Unshipped.txt
Show resolved
Hide resolved
bgavrilMS
reviewed
Dec 17, 2025
| /// Static initializer that registers the KeyGuard attestation provider | ||
| /// when the KeyAttestation assembly is loaded. | ||
| /// </summary> | ||
| internal static class AttestationProviderInitializer |
bgavrilMS
reviewed
Dec 17, 2025
| /// Implementation of IAttestationProvider for KeyGuard attestation. | ||
| /// This provider is automatically registered when the KeyAttestation package is loaded. | ||
| /// </summary> | ||
| internal class KeyGuardAttestationProvider : IAttestationProvider |
Member
There was a problem hiding this comment.
I think this PR is doing too much. The existing logic just sets builder.CommonParameters.AttestationTokenProvider. Why does this need to change with introduction of registry, new interfaces and classes etc. I do not understand the new design.
bgavrilMS
reviewed
Dec 17, 2025
| [assembly: InternalsVisibleTo("Microsoft.Identity.Client.Desktop.WinUI3" + KeyTokens.MSAL)] | ||
| [assembly: InternalsVisibleTo("Microsoft.Identity.Client.Broker" + KeyTokens.MSAL)] | ||
| [assembly: InternalsVisibleTo("Microsoft.Identity.Client.MtlsPop" + KeyTokens.MSAL)] | ||
| [assembly: InternalsVisibleTo("Microsoft.Identity.Client.KeyAttestation" + KeyTokens.MSAL)] |
Member
There was a problem hiding this comment.
I think the AI was actually trying to eliminate this InternalsVisibleTo and came up with this new design. But you kept it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5591