MSI POP Attestation #5612
+652
−323
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System; | ||
| using System.Runtime.InteropServices; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.Identity.Client.ManagedIdentity; | ||
|
|
||
| namespace Microsoft.Identity.Client.KeyAttestation.Attestation | ||
| { | ||
| /// <summary> | ||
| /// Implementation of IAttestationProvider for KeyGuard attestation. | ||
| /// This provider is automatically registered when the KeyAttestation package is loaded. | ||
| /// </summary> | ||
| internal class KeyGuardAttestationProvider : IAttestationProvider | ||
|
Member
There was a problem hiding this comment. I think this PR is doing too much. The existing logic just sets |
||
| { | ||
| public async Task<ManagedIdentity.AttestationResult> AttestKeyGuardAsync( | ||
| string attestationEndpoint, | ||
| SafeHandle keyHandle, | ||
| string clientId, | ||
| CancellationToken cancellationToken) | ||
| { | ||
| try | ||
| { | ||
| // Call the existing PopKeyAttestor implementation | ||
| var result = await PopKeyAttestor.AttestKeyGuardAsync( | ||
| attestationEndpoint, | ||
| keyHandle, | ||
| clientId, | ||
| cancellationToken).ConfigureAwait(false); | ||
|
|
||
| // Map the result to the MSAL interface types | ||
| return new ManagedIdentity.AttestationResult | ||
| { | ||
| Status = result.Status == AttestationStatus.Success | ||
| ? ManagedIdentity.AttestationStatus.Success | ||
| : ManagedIdentity.AttestationStatus.Failed, | ||
| Jwt = result.Jwt, | ||
| ErrorMessage = result.ErrorMessage, | ||
| NativeErrorCode = result.NativeErrorCode | ||
| }; | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| return new ManagedIdentity.AttestationResult | ||
| { | ||
| Status = ManagedIdentity.AttestationStatus.Failed, | ||
| ErrorMessage = ex.Message, | ||
| NativeErrorCode = -1 | ||
| }; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Static initializer that registers the KeyGuard attestation provider | ||
| /// when the KeyAttestation assembly is loaded. | ||
| /// </summary> | ||
| internal static class AttestationProviderInitializer | ||
|
|
||
| { | ||
| static AttestationProviderInitializer() | ||
| { | ||
| // Register the provider when this type is first accessed | ||
| AttestationProviderRegistry.RegisterProvider(new KeyGuardAttestationProvider()); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Method to force static constructor execution. | ||
| /// Called from module initializer. | ||
| /// </summary> | ||
| internal static void Initialize() | ||
| { | ||
| // This method body is intentionally empty. | ||
| // Its purpose is to trigger the static constructor above. | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| #if NETSTANDARD | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.