Skip to content

Add Clone bound to BitIter in Jet::decode() #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
topologoanatom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Clone bound to BitIter in Jet::decode() #343

topologoanatom wants to merge 1 commit into from

Conversation

@topologoanatom
Copy link

@topologoanatom topologoanatom commented Feb 11, 2026

Fixes #342

apoelstra
apoelstra reviewed Feb 11, 2026
View reviewed changes
src/bit_encoding/decode.rs
}

pub fn decode_expression<'brand, I: Iterator<Item = u8>, J: Jet>(
pub fn decode_expression<'brand, I: Iterator<Item = u8> + Clone, J: Jet>(
Copy link
Collaborator

@apoelstra apoelstra Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2db8d12:

This bound is not necessary. Neither are any of the other bounds you added.

@apoelstra
Copy link
Collaborator

apoelstra commented Feb 11, 2026

Please don't submit slop to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Clone bound to BitIter in decode function of Jet trait

2 participants

@topologoanatom @apoelstra