linoy project #26
linoy project #26
Conversation
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Hey I left you some comments, to avoid repeat myself take every comment and implement the changes in every place in your code
| .attribution { font-size: 11px; text-align: center; } | ||
| .attribution a { color: hsl(228, 45%, 44%); } | ||
| </style> | ||
| <link rel="stylesheet" type="text/css" href="./style.css"> |
| <div class="frontBox"> | ||
| <div class="allText"> | ||
|
|
||
| <h1 class="textPage" id="higlight">Stay updated!</h1> |
There was a problem hiding this comment.
You dont really need both id and class
|
|
||
| <div class="mail"> | ||
| <label class="textPage" for="email" id="e-mail">Email address</label> | ||
| <input id="email" type="text" placeholder="email@example.com"> |
There was a problem hiding this comment.
Same here why do you need id? you could achieve the same with class
| const errorMsg = document.getElementById("errorMsg"); | ||
|
|
||
| function isValidEmail(email) { | ||
| const regex = /^[a-zA-Z]{1,15}@[a-zA-Z]{1,15}\.com$/; |
There was a problem hiding this comment.
This regex should be saved inside constant variable
| button.addEventListener("click", function() { | ||
| console.log("Button clicked!"); | ||
| const emailValue = emailInput.value.trim(); | ||
| console.log("Email" ,emailValue); |
There was a problem hiding this comment.
Remove your consoles, we dont want to push consoles.
Also I would add the ? symbol for null safety on the email
| @@ -0,0 +1,89 @@ | |||
| body { | |||
| background-color: hsl(235, 18%, 26%); | |||
There was a problem hiding this comment.
colors should come from css variables
| } | ||
|
|
||
| @font-face { | ||
| font-family: 'myFont2'; |
| visibility: hidden; /* JS ישנה ל-visible */ | ||
| } | ||
|
|
||
| #e-mail { |
There was a problem hiding this comment.
be consistent with your naming, like-this or likeThis
| align-items: center; | ||
| justify-content: center; | ||
| border-radius: 5%; | ||
| height: 500px; |
There was a problem hiding this comment.
Will this be responsive in mobile?
| @@ -0,0 +1,15 @@ | |||
|
|
|||
| <html> | |||
There was a problem hiding this comment.
Where are you using this html page?
3 participants
No description provided.