linoy project #26
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| document.addEventListener("DOMContentLoaded", function() { | ||
| const emailInput = document.getElementById("email"); | ||
| const button = document.getElementById("buttonSub"); | ||
| const errorMsg = document.getElementById("errorMsg"); | ||
|
|
||
| function isValidEmail(email) { | ||
| const regex = /^[a-zA-Z]{1,15}@[a-zA-Z]{1,15}\.com$/; | ||
|
Member
There was a problem hiding this comment. This regex should be saved inside constant variable |
||
| return regex.test(email); | ||
| } | ||
|
|
||
| button.addEventListener("click", function() { | ||
| console.log("Button clicked!"); | ||
| const emailValue = emailInput.value.trim(); | ||
| console.log("Email" ,emailValue); | ||
|
Member
There was a problem hiding this comment. Remove your consoles, we dont want to push consoles. Also I would add the |
||
|
|
||
| // שדה ריק | ||
|
Member
There was a problem hiding this comment. comments that explain what the code is doing are bad, the code should explain itself. Also, never write in hebrew |
||
| if (emailValue === "") { | ||
| errorMsg.textContent = "You Need To Enter An EMAIL first"; | ||
| errorMsg.style.visibility = "visible"; | ||
|
Member
There was a problem hiding this comment. We dont want to change the styles via js, do it with dynamic classes and css |
||
| emailInput.style.border = "2px solid red"; | ||
| return; | ||
| } | ||
|
|
||
| // פורמט לא תקין | ||
| if (!isValidEmail(emailValue)) { | ||
| errorMsg.textContent = "Wrong Mail Format"; | ||
| errorMsg.style.visibility = "visible"; | ||
| emailInput.style.border = "2px solid red"; | ||
| return; | ||
| } | ||
|
|
||
| // הצלחה | ||
| errorMsg.style.visibility = "hidden"; | ||
| emailInput.style.border = "2px solid green"; | ||
|
|
||
| // מעבר לעמוד אחר | ||
| window.location.href = "success.html"; | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| body { | ||
| background-color: hsl(235, 18%, 26%); | ||
|
Member
There was a problem hiding this comment. colors should come from css variables |
||
| } | ||
|
|
||
| .backOfWite { | ||
| display: flex; | ||
| flex-direction: row; | ||
| align-items: center; | ||
| justify-content: center; | ||
| margin-top: 5%; | ||
| } | ||
|
|
||
| .frontBox { | ||
| display: flex; | ||
| flex-direction: row; | ||
| background-color: white; | ||
| justify-content: space-around; | ||
| border-radius: 5%; | ||
| } | ||
|
|
||
| .allText { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: space-between; | ||
| margin-left: 5%; | ||
| margin-bottom: 10%; | ||
| margin-top: 5%; | ||
| } | ||
|
|
||
| .checkText { | ||
| display: flex; | ||
| flex-direction: row; | ||
| gap: 5%; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: 'myFont1'; | ||
| src: url('./assets/fonts/Roboto-Regular.ttf') format('truetype'); | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: 'myFont2'; | ||
|
|
||
| src: url('./assets/fonts/Roboto-Bold.ttf') format('truetype'); | ||
| } | ||
|
|
||
| .textPage { | ||
| font-family: "myFont1", sans-serif; | ||
| font-size: 16px; | ||
| font-weight: 400; | ||
| } | ||
|
|
||
| #higlight { | ||
| font-family: "myFont2", sans-serif; | ||
| font-size: 50px; | ||
| font-weight: 700; | ||
| } | ||
|
|
||
| .mail { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 10px; | ||
| margin-top: 5%; | ||
| } | ||
|
|
||
| #errorMsg { | ||
| color: red; | ||
| font-size: 12px; | ||
| margin-top: -5px; | ||
| visibility: hidden; /* JS ישנה ל-visible */ | ||
| } | ||
|
|
||
| #e-mail { | ||
|
Member
There was a problem hiding this comment. be consistent with your naming, |
||
| font-family: "myFont2", sans-serif; | ||
| font-size: 13px; | ||
| font-weight: 900; | ||
| } | ||
|
|
||
| #buttonSub { | ||
| background-color: hsl(234, 29%, 20%); | ||
| color: white; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .mail input, #buttonSub { | ||
| width: 300px; | ||
| padding: 12px; | ||
| border-radius: 5px; | ||
| box-sizing: border-box; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| body { | ||
| background-color: hsl(235, 18%, 26%); | ||
| } | ||
|
|
||
| .backOfWite { | ||
| display: flex; | ||
| flex-direction: row; | ||
| align-items: center; | ||
| justify-content: center; | ||
| margin-top: 5%; | ||
| } | ||
|
|
||
| .frontBox { | ||
| display: flex; | ||
| flex-direction: row; | ||
| background-color: rgb(246, 125, 12); | ||
| align-items: center; | ||
| justify-content: center; | ||
| border-radius: 5%; | ||
| height: 500px; | ||
|
Member
There was a problem hiding this comment. Will this be responsive in mobile? |
||
| width: 500px; | ||
| } | ||
|
|
||
| #WELCOMEH{ | ||
| color: white; | ||
| font-size: 50px; | ||
| font-weight: bold; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
|
|
||
| <html> | ||
|
Member
There was a problem hiding this comment. Where are you using this html page? |
||
| <head> | ||
| <link rel="stylesheet" type="text/css" href="./stylsSuccess.css"> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div class="backOfWite"> | ||
| <div class="frontBox"> | ||
| <p id="WELCOMEH">WELCOME !!!!!!</p> | ||
| </div> | ||
| </div> | ||
| </body> | ||
|
|
||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need the type?