Skip to content

🎨 Palette: Add keyboard instructions and improve screen reader accessibility for Mario game score #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EiJackGH wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🎨 Palette: Add keyboard instructions and improve screen reader accessibility for Mario game score #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72446d3
🎨 Palette: Add keyboard instructions and improve screen reader access…
google-labs-jules[bot] Jun 8, 2026
0a26e61
🎨 Palette: Add keyboard instructions and improve screen reader access…
google-labs-jules[bot] Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@
## 2025-03-23 - Game Key Scrolling
**Learning:** Browsers natively scroll the page when users press Space or Arrow keys. When building a web-based game, this creates a frustrating UX where the game viewport jumps around while playing.
**Action:** Always call `e.preventDefault()` on keydown events for typical game controls ("Space", "ArrowUp", etc.) when the focus is on a game container or the body.
## 2026-06-08 - [Extracting Static Text from ARIA Live Regions]
**Learning:** Do not place static text (like instructions or static labels such as 'Score: ') inside an `aria-live` region, as it forces screen readers to unnecessarily repeat the static text every time the dynamic content updates.
**Action:** Extract static text into a separate sibling element so the screen reader only reads the dynamic changes.
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
numpy
pandas
requests
venv
20 changes: 17 additions & 3 deletions src/views/mario-game.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,21 +44,35 @@
background: #2ecc71;
}

#score {
#score-container {
position: absolute;
top: 10px;
left: 10px;
color: white;
font-size: 20px;
font-family: Arial;
}

#instructions {
position: absolute;
top: 40px;
left: 10px;
color: white;
font-size: 14px;
font-family: Arial;
opacity: 0.8;
}
</style>
</head>

<body>

<div id="game">
<div id="score">Score: 0</div>
<div id="score-container">
<span>Score: </span>
<span id="score" aria-live="polite" aria-atomic="true">0</span>
</div>
<div id="instructions">Press Space or Up Arrow to jump</div>
<div id="mario"></div>
<div class="ground"></div>
</div>
Expand Down Expand Up @@ -118,7 +132,7 @@
clearInterval(move);
goomba.remove();
score++;
scoreText.innerText = "Score: " + score;
scoreText.innerText = score;
} else {
position -= 6;
goomba.style.left = position + "px";
Expand Down
Loading