Skip to content

🎨 Palette: Add keyboard instructions and accessibility to Mario game#194

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-a11y-6090730753538354458
Open

🎨 Palette: Add keyboard instructions and accessibility to Mario game#194
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-a11y-6090730753538354458

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

Added visible keyboard instructions ("Press Space or Up Arrow to jump") to the Mario game overlay and made the dynamic score counter screen-reader accessible.

🎯 Why

New users often don't know the controls for embedded mini-games, leading to frustration. By making the controls visible, the interaction becomes immediately intuitive.

♿ Accessibility

Added aria-live="polite" and aria-atomic="true" to the #score element so screen readers gracefully announce the score updates as the game progresses. The static instructions were purposefully kept outside the live region to prevent redundant announcements on every score tick.

📸 Before/After

(Verified locally using Playwright screenshots)

  • Before: Only the score was visible. Screen readers did not announce score updates.
  • After: Clear keyboard instructions appear below the score. Screen readers announce score changes naturally.

PR created automatically by Jules for task 6090730753538354458 started by @EiJackGH

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant