Migrate `SearchFiltersParticipantsSelector` and `SearchFiltersChatsSelector` by zfurtak · Pull Request #81416 · Expensify/App

zfurtak · 2026-02-04T15:22:11Z

Explanation of Change

In this PR I migrate 2 components: SearchFiltersParticipantsSelector and SearchFiltersChatsSelector, because I had to change some typed that are shared between them.
These 2 selectors are very similar imo, so it shouldn't be problematic.

Note

#80898 should be merged first

Fixed Issues

$ #65658
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…st prop

codecov · 2026-02-04T15:33:45Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/libs/PolicyUtils.ts	`55.29% <100.00%> (+0.05%)`	⬆️
src/libs/ReportUtils.ts	`72.65% <ø> (+0.04%)`	⬆️
src/libs/SidebarUtils.ts	`79.44% <ø> (ø)`
src/pages/NewChatPage.tsx	`75.00% <100.00%> (ø)`
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx	`4.08% <0.00%> (-0.09%)`	⬇️
src/libs/OptionsListUtils/index.ts	`77.97% <75.00%> (-0.05%)`	⬇️
...ges/iou/request/MoneyRequestAccountantSelector.tsx	`0.00% <0.00%> (ø)`
...pages/iou/request/MoneyRequestAttendeeSelector.tsx	`0.00% <0.00%> (ø)`
...s/iou/request/MoneyRequestParticipantsSelector.tsx	`0.00% <0.00%> (ø)`
... and 4 more
... and 26 files with indirect coverage changes

zfurtak · 2026-02-04T15:42:34Z

src/pages/NewChatPage.tsx

        reportAttributesDerived,
    );
-    sections.push(formatResults.section);
+    sections.push({...formatResults.section, title: undefined, shouldShow: true});


This is temporary so the type is okay, will be changed while migrating NewChatPage

zfurtak · 2026-02-04T15:43:05Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

        );

-        newSections.push(formatResults.section);
+        newSections.push({...formatResults.section, title: undefined, shouldShow: true});


This is temporary so the type is okay, will be changed while migrating MoneyRequiestParticipantsSelector

zfurtak · 2026-02-04T15:43:21Z

src/pages/iou/request/MoneyRequestAccountantSelector.tsx

            reportAttributesDerived,
        );
-        newSections.push(formatResults.section);
+        newSections.push({...formatResults.section, title: undefined, shouldShow: true});


This is temporary so the type is okay, will be changed while migrating MoneyRequestAccountantSelector

zfurtak · 2026-02-04T15:44:55Z

src/libs/OptionsListUtils/index.ts

 * Get the participant option for a report.
 */
-function getParticipantsOption(participant: OptionData | Participant, personalDetails: OnyxEntry<PersonalDetailsList>): Participant {
+function getParticipantsOption(participant: OptionData | Participant, personalDetails: OnyxEntry<PersonalDetailsList>): Participant & {keyForList: string} {


Added & {keyForList: string} here cause changing this type in Participant cause over 150 ts errors and I don't think it's worth changing and fixing som many cases.

sharabai and others added 10 commits February 4, 2026 12:00

refactor ro use new SelectionList

d0bcf40

Modify OptionData to make keyForList required

dcee078

add sentry label to NewChatPage

043a0b3

refactor to address some PR comments

a888472

Fix failing lint CI

0019f09

Revert to empty string as a default value before filling out keyForLi…

084ffa9

…st prop

Rename Sentry label

8756bd3

Change to string

ef8d0bf

Add keyForList first where it makes sense

3c33c75

Migrate SearchFiltersSelectors: Chats and Participants

3b04263

melvin-bot bot assigned zfurtak Feb 4, 2026

Merge branch 'main' into @zfurtak/migrate-SearchFiltersChatsSelector

33c7bb2

zfurtak mentioned this pull request Feb 4, 2026

[SelectionList Improvements][Phase 4] Migrate sectioned list usages (~25) #65658

Open

zfurtak commented Feb 4, 2026

View reviewed changes

Remove manual memoization from SearchFiltersChatsSelector

63f2a28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `SearchFiltersParticipantsSelector` and `SearchFiltersChatsSelector`#81416

Migrate `SearchFiltersParticipantsSelector` and `SearchFiltersChatsSelector`#81416
zfurtak wants to merge 12 commits intoExpensify:mainfrom
software-mansion-labs:@zfurtak/migrate-SearchFiltersChatsSelector

zfurtak commented Feb 4, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 4, 2026 •

edited by github-actions bot

Loading

Uh oh!

zfurtak Feb 4, 2026

Uh oh!

zfurtak Feb 4, 2026

Uh oh!

zfurtak Feb 4, 2026

Uh oh!

zfurtak Feb 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zfurtak commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 4, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zfurtak Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

zfurtak Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

zfurtak Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

zfurtak Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zfurtak commented Feb 4, 2026 •

edited

Loading

codecov bot commented Feb 4, 2026 •

edited by github-actions bot

Loading

zfurtak Feb 4, 2026 •

edited

Loading