Capture user email per log line to prevent dissociation#893
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
52 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
amyevans
previously approved these changes
Feb 3, 2026
Contributor
amyevans
left a comment
amyevans
left a comment
There was a problem hiding this comment.
A few thoughts but not blocking since I know there's urgency here!
Also, I wonder if getting the email for every log line now might negatively affect performance. Something to keep an eye on if we can't measure it in advance properly
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Great suggestions @amyevans. Updated! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes logger to capture user email at the moment each log line is created, preventing email dissociation when Onyx.clear is called before logs are sent.
Fixed Issues
$ Expensify/App#81259
Tests
Unit tests added in dependent App PR verify that logs retain user email even when session is cleared between log creation and upload.
QA
No QA needed - this is a library change with automated test coverage.
Made with Cursor