chore: Update NitroSQLite to use new DatabaseQueue implementation#700
Merged
mountiny merged 2 commits intoExpensify:mainfrom Nov 11, 2025
Merged
Conversation
DatabaseQueue implementationDatabaseQueue implementation
Contributor
|
Putting this on hold so we dont accidentally merge it before we get through with next onyx update in App that is handled by @VickyStash Expensify/App#74489 |
DatabaseQueue implementationDatabaseQueue implementation
DatabaseQueue implementationDatabaseQueue implementation
54 tasks
situchan
approved these changes
Nov 10, 2025
mountiny
approved these changes
Nov 10, 2025
Contributor
mountiny
left a comment
There was a problem hiding this comment.
HOLDING for Expensify/App#74489 deployment to prod
DatabaseQueue implementationDatabaseQueue implementation
DatabaseQueue implementationDatabaseQueue implementation
mountiny
approved these changes
Nov 11, 2025
Contributor
mountiny
left a comment
There was a problem hiding this comment.
Previous bump is now in production so we can move this one ahead
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mountiny @shubham1206agra
Details
This PR updates NitroSQLite to version
9.2.0which includes a newDatabaseQueueimplementation, to avoid conflicts with overlapping/simultaneous transactions and batch operations. This also requires Nitro Modules to be updated to version0.27.2.The
DatabaseQueuewas introduced into in NitroSQLite in margelo/react-native-nitro-sqlite#227Related Issues
Expensify/App#73793 (comment)
Automated Tests
None.
Manual Tests
[SqlExecutionError] cannot rollback - no transaction is active[SqlExecutionError] cannot start a transaction within a transactionAuthor Checklist
### Related Issuessection aboveTestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop