ci: extend PR-validation triggers to release/v* branches by ChrisonSimtian · Pull Request #291 · Fallout-build/Fallout

ChrisonSimtian · 2026-05-29T06:53:32Z

Fixes the CI chicken-and-egg surfaced by #290. Branch protection on release/v11 (applied in #270) requires ubuntu-latest, but no workflow was firing it for PRs against this branch — they BLOCKED indefinitely.

What changes

.github/workflows/ubuntu-latest.yml — adds release/v* to pull_request.branches.
.github/workflows/ubuntu-latest-docs.yml — same.
build/Build.cs — new ReleaseBranchPattern = "release/v*" constant alongside MainBranch.
build/Build.CI.GitHubActions.cs — OnPullRequestBranches on the ubuntu-latest [GitHubActions] attribute extended to include both. Keeps the auto-generator output in sync with the hand-edits so a future dotnet fallout --generate-configuration doesn't undo this.

What's out of scope

windows-latest and macos-latest stay OnPushBranches only — they're post-merge validation, not PR gates. They'll fire on push to release/v* automatically once release/v* is also added to their OnPushBranches... but actually those are still on MainBranch only. Follow-up worth filing: extend the push triggers too so release/v11 gets the same post-merge cross-platform validation main has. Not blocking this PR.

Propagation to release/v11

After this lands on main, the same workflow files need to be brought across to release/v11 — same chicken-and-egg until release/v11 itself has the updated workflows. Plan:

This PR merges to main (normal CI flow, since it targets main).
I open a follow-up PR cherry-picking these workflow updates to release/v11.
That follow-up PR is admin-bypass-merged (one-time, since CI still won't fire on it).
After step 3, release/v11 has working CI, and chore(versioning): add release/v11 to publicReleaseRefSpec #290 + future release-branch PRs run normally.

Test plan

YAML parses
Build.cs still compiles (the constants are simple)
CI green on this PR

Refs milestone #13. Unblocks #290.

🤖 Generated with Claude Code

Branch protection on `release/v11` (applied in #270) requires the `ubuntu-latest` status check, but `.github/workflows/ubuntu-latest.yml` and `.github/workflows/ubuntu-latest-docs.yml` only fired on PRs targeting `main`. Net effect: PRs against `release/v11` had no CI and got BLOCKED by branch protection waiting for a check that never reported — a chicken-and-egg that surfaced when #290 (the NB.GV publicReleaseRefSpec tweak) couldn't merge. Changes: - Both workflows now list `main` AND `release/v*` under `pull_request.branches:`. - `build/Build.cs` gains a `ReleaseBranchPattern = "release/v*"` constant alongside `MainBranch`. - `build/Build.CI.GitHubActions.cs` extends `OnPullRequestBranches` on the ubuntu-latest `[GitHubActions]` attribute to include both branches, so next time the auto-generator runs it produces the same YAML. Out of scope: `windows-latest` and `macos-latest` stay `OnPushBranches` only (post-merge / release validation). They run after merge regardless of base branch via the push trigger. After this lands on main, the same workflow files need to be brought across to `release/v11` (separate PR — same chicken-and-egg until release/v11 also has the updated workflows; will be admin-bypass-merged once). Refs milestone #13. Unblocks #290. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Branch protection on `release/v11` (applied in #270) requires the `ubuntu-latest` status check, but `.github/workflows/ubuntu-latest.yml` and `.github/workflows/ubuntu-latest-docs.yml` only fired on PRs targeting `main`. Net effect: PRs against `release/v11` had no CI and got BLOCKED by branch protection waiting for a check that never reported — a chicken-and-egg that surfaced when #290 (the NB.GV publicReleaseRefSpec tweak) couldn't merge. Changes: - Both workflows now list `main` AND `release/v*` under `pull_request.branches:`. - `build/Build.cs` gains a `ReleaseBranchPattern = "release/v*"` constant alongside `MainBranch`. - `build/Build.CI.GitHubActions.cs` extends `OnPullRequestBranches` on the ubuntu-latest `[GitHubActions]` attribute to include both branches, so next time the auto-generator runs it produces the same YAML. Out of scope: `windows-latest` and `macos-latest` stay `OnPushBranches` only (post-merge / release validation). They run after merge regardless of base branch via the push trigger. After this lands on main, the same workflow files need to be brought across to `release/v11` (separate PR — same chicken-and-egg until release/v11 also has the updated workflows; will be admin-bypass-merged once). Refs milestone #13. Unblocks #290. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…book + ADR (#276, #277) (#295) Closes #276 and #277. Captures the full milestone #13 outcome in three places now that all the moving parts are in production: CONTRIBUTING.md - "Where to start" updated: PRs target main, releases ship from release/vN, hotfix flow noted. - "After opening a PR" updated to reflect ubuntu-latest now firing on release/v* PRs too (post #291/#292), with the windows/macos parity follow-up linked (#293). - New "Releases" section pointing contributors at the maintainer runbook. docs/branching-and-release.md (new) - Maintainer reference: branches at a glance, channel taxonomy, full step-by-step for cutting a release (gh release create + the env approval-gate prompt), hotfix workflow (cherry-pick recipe), workflow_dispatch fallback for re-running partial publishes, cutting a new release/vN, deprecating an old one, tag-protection ruleset. docs/adr/0001-release-branch-model.md (new — seeds docs/adr/) - Architecture Decision Record covering Context (consumer-facing noise from auto-release; no hotfix path), Decision (the model), and Consequences (positive + negative + neutral). Includes the four alternatives we considered and rejected. - Cites the consumer-pain-first principle (saved as agent memory) that drove the cutover timing. - Status: Accepted. Implementation already shipped. AGENTS.md - "Where to look next" links the new branching-and-release.md doc and the docs/adr/ directory so AI agents reading the brief discover them. CHANGELOG.md - Umbrella entry for milestone #13 under [Unreleased] — 11.0 → Process, summarising all sub-issues that landed: #269, #270, #272, #273, #274, #275, #291, #292. Per the pattern set in #269's closing comment — one consolidated entry rather than nine fragmented per-sub-issue entries. Refs milestone #13, RFC #267. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Closes #293. Parity follow-up to #291 (which extended PR-validation triggers to release/v*). After this: - windows-latest.yml — pull_request trigger unchanged (still PR-only on main, by design); push trigger extends to main AND release/v*. - macos-latest.yml — same. - build/Build.CI.GitHubActions.cs — OnPushBranches on both windows and macos [GitHubActions] entries gain ReleaseBranchPattern alongside MainBranch, so next auto-regen produces matching YAML. Effect: a hotfix merged to release/v11 now triggers Windows + macOS post-merge validation, same as merges to main. Cross-platform regressions in release-branch hotfixes surface immediately as red commits on the release branch, not later when someone tries to cut a release. Out of scope: extending pull_request triggers on windows/macos to fire on release/v* PRs. The current PR gate (ubuntu-latest only) is a deliberate cost trade-off documented in docs/agents/release-and-versioning.md. Refs milestone #13. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

ChrisonSimtian added this to the Release-branch model & multi-channel CD milestone May 29, 2026

ChrisonSimtian added the target/v11 label May 29, 2026

ChrisonSimtian merged commit 0371ee1 into main May 29, 2026
1 check passed

ChrisonSimtian deleted the ci/extend-pr-triggers-to-release-branches branch May 29, 2026 06:59

ChrisonSimtian mentioned this pull request May 29, 2026

ci: propagate PR-validation triggers to release/v11 (cherry-pick #291) #292

Merged

This was referenced May 29, 2026

Extend windows-latest + macos-latest post-merge triggers to release/v* #293

Closed

docs: release-branch model — CONTRIBUTING + branching-and-release runbook + ADR #295

Merged

ChrisonSimtian mentioned this pull request May 29, 2026

ci: extend windows-latest + macos-latest push triggers to release/v* #297

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ci: extend PR-validation triggers to release/v* branches#291

ci: extend PR-validation triggers to release/v* branches#291
ChrisonSimtian merged 1 commit into
mainfrom
ci/extend-pr-triggers-to-release-branches

ChrisonSimtian commented May 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

ChrisonSimtian commented May 29, 2026

What changes

What's out of scope

Propagation to release/v11

Test plan

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant