Convert the :navigation cluster to command types (#392)#403
Open
ChrisonSimtian wants to merge 1 commit into
Open
Convert the :navigation cluster to command types (#392)#403ChrisonSimtian wants to merge 1 commit into
ChrisonSimtian wants to merge 1 commit into
Conversation
ChrisonSimtian
added
the
target/2026
ChrisonSimtian
force-pushed
the
cli-cmd-navigation
branch
from
50ae5bf to
c82d9e6
Compare
ChrisonSimtian
changed the base branch from
cli-command-dispatch-foundation
to
cli-cmd-cake
ChrisonSimtian
force-pushed
the
cli-cmd-cake
branch
from
8dff34f to
4e5fac1
Compare
Lift the five directory-navigation handlers into discrete command types with their names preserved (GetNextDirectory, PopDirectory, PushWithCurrentRootDirectory, PushWithParentRootDirectory, PushWithChosenRootDirectory) so the companion shell functions keep working. Shared per-session state moves into an internal NavigationSession helper; PushWithChosenRootDirectory takes IConsolePrompts via the constructor. Replaces the five DelegateCommand adapters; deletes Program.Navigation.cs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
cli-cmd-navigation
branch
from
c82d9e6 to
fb50596
Compare
Collaborator
Author
|
Testing note: no command unit test in this PR. The navigation commands read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #392. Stacked on #394 — merge after it lands.
Per the locked decision, the five navigation verbs become discrete commands with names preserved (
GetNextDirectory,PopDirectory,PushWithCurrentRootDirectory,PushWithParentRootDirectory,PushWithChosenRootDirectory) so the documented shell functions (nuke-/nuke//nuke./nuke..) keep working. Shared per-session state moves into aninternal NavigationSession;PushWithChosenRootDirectoryCommandtakesIConsolePrompts. Replaces the fiveDelegateCommandadapters; deletesProgram.Navigation.cs.Verification
Fallout.Cli.Tests30 pass.🤖 Generated with Claude Code