Skip to content

fix: use incognito mode in checklists#173

Merged
naveensingh merged 2 commits intoFossifyOrg:mainfrom
TopFox:checklist_incognito_mode
Jul 6, 2025
Merged

fix: use incognito mode in checklists#173
naveensingh merged 2 commits intoFossifyOrg:mainfrom
TopFox:checklist_incognito_mode

Conversation

@TopFox
Copy link
Copy Markdown
Contributor

@TopFox TopFox commented Jul 5, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

The EditTextDialog and NewChecklistItemDialog now use the keyboard incognito mode as requested in #74

Before/After Screenshots/Screen Record

Before can be seen in the issue
After:

Fixes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • All checks are passing.

@TopFox TopFox requested a review from naveensingh as a code owner July 5, 2025 20:40
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The common logic should be extracted to an extension function like the following:

package org.fossify.notes.extensions

import android.view.inputmethod.EditorInfo
import android.widget.TextView
import org.fossify.commons.extensions.removeBit

fun TextView.maybeRequestIncognito() {
    imeOptions = if (context.config.useIncognitoMode) {
        imeOptions or EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING
    } else {
        imeOptions.removeBit(EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING)
    }
}

Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@naveensingh naveensingh merged commit 589a85c into FossifyOrg:main Jul 6, 2025
5 checks passed
@TopFox TopFox deleted the checklist_incognito_mode branch July 9, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incognito mode is not used in checklists

2 participants