Skip to content

fix: use incognito mode in checklists #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 2 commits into from
Jul 6, 2025
Merged

fix: use incognito mode in checklists #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff20817
fix: use incognito mode in checklists
TopFox Jul 5, 2025
e4da7e8
fix: use an extension function to request incognito mode
TopFox Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/kotlin/org/fossify/notes/dialogs/EditTaskDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ import android.app.Activity
import android.content.DialogInterface.BUTTON_POSITIVE
import org.fossify.commons.extensions.*
import org.fossify.notes.databinding.DialogRenameChecklistItemBinding
import org.fossify.notes.extensions.maybeRequestIncognito

class EditTaskDialog(val activity: Activity, val oldTitle: String, callback: (newTitle: String) -> Unit) {
init {
val binding = DialogRenameChecklistItemBinding.inflate(activity.layoutInflater).apply {
checklistItemTitle.setText(oldTitle)
checklistItemTitle.maybeRequestIncognito()
}

activity.getAlertDialogBuilder()
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/kotlin/org/fossify/notes/dialogs/NewChecklistItemDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import org.fossify.notes.R
import org.fossify.notes.databinding.DialogNewChecklistItemBinding
import org.fossify.notes.databinding.ItemAddChecklistBinding
import org.fossify.notes.extensions.config
import org.fossify.notes.extensions.maybeRequestIncognito

class NewChecklistItemDialog(
val activity: Activity,
Expand Down Expand Up @@ -94,6 +95,9 @@ class NewChecklistItemDialog(
titles.add(titleEditText)
binding.checklistHolder.addView(this.root)
}

titleEditText.maybeRequestIncognito()

activity.updateTextColors(binding.checklistHolder)
binding.dialogHolder.post {
binding.dialogHolder.fullScroll(View.FOCUS_DOWN)
Expand Down
13 changes: 13 additions & 0 deletions app/src/main/kotlin/org/fossify/notes/extensions/TextView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package org.fossify.notes.extensions

import android.view.inputmethod.EditorInfo
import android.widget.TextView
import org.fossify.commons.extensions.removeBit

fun TextView.maybeRequestIncognito() {
imeOptions = if (context.config.useIncognitoMode) {
imeOptions or EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING
} else {
imeOptions.removeBit(EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING)
}
}
9 changes: 2 additions & 7 deletions app/src/main/kotlin/org/fossify/notes/fragments/TextFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import android.view.LayoutInflater
import android.view.MotionEvent
import android.view.View
import android.view.ViewGroup
import android.view.inputmethod.EditorInfo
import android.view.inputmethod.InputMethodManager
import android.widget.ImageView
import android.widget.TextView
Expand All @@ -28,6 +27,7 @@ import org.fossify.notes.databinding.NoteViewHorizScrollableBinding
import org.fossify.notes.databinding.NoteViewStaticBinding
import org.fossify.notes.extensions.config
import org.fossify.notes.extensions.getPercentageFontSize
import org.fossify.notes.extensions.maybeRequestIncognito
import org.fossify.notes.extensions.updateWidgets
import org.fossify.notes.helpers.MyMovementMethod
import org.fossify.notes.helpers.NOTE_ID
Expand Down Expand Up @@ -172,12 +172,7 @@ class TextFragment : NoteFragment() {
}
}
}

imeOptions = if (config.useIncognitoMode) {
imeOptions or EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING
} else {
imeOptions.removeBit(EditorInfo.IME_FLAG_NO_PERSONALIZED_LEARNING)
}
maybeRequestIncognito()
}

noteEditText.setOnTouchListener { v, event ->
Expand Down
Loading